git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Keeping <john@keeping.me.uk>
To: Antoine Pelisse <apelisse@gmail.com>
Cc: Max Horn <max@quendi.de>, git <git@vger.kernel.org>,
	Johannes Sixt <j6t@kdbg.org>, Junio C Hamano <gitster@pobox.com>
Subject: [PATCH] combine-diff: suppress a clang warning
Date: Thu, 17 Jan 2013 11:23:30 +0000	[thread overview]
Message-ID: <20130117112330.GE4574@serenity.lan> (raw)
In-Reply-To: <20130117110008.GD4574@serenity.lan>

When compiling combine-diff.c, clang 3.2 says:

    combine-diff.c:1006:19: warning: adding 'int' to a string does not
	    append to the string [-Wstring-plus-int]
		prefix = COLONS + offset;
			 ~~~~~~~^~~~~~~~
    combine-diff.c:1006:19: note: use array indexing to silence this warning
		prefix = COLONS + offset;
				^
			 &      [       ]

Suppress this by making the suggested change.

Signed-off-by: John Keeping <john@keeping.me.uk>
---
On Thu, Jan 17, 2013 at 11:00:08AM +0000, John Keeping wrote:
> On Thu, Jan 17, 2013 at 11:32:39AM +0100, Antoine Pelisse wrote:
> There is one remaining warning on pu which hasn't been discussed in this
> thread as far as I can see.  I'll send a patch shortly.

... and here it is.

 combine-diff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/combine-diff.c b/combine-diff.c
index bb1cc96..dba4748 100644
--- a/combine-diff.c
+++ b/combine-diff.c
@@ -1003,7 +1003,7 @@ static void show_raw_diff(struct combine_diff_path *p, int num_parent, struct re
 		offset = strlen(COLONS) - num_parent;
 		if (offset < 0)
 			offset = 0;
-		prefix = COLONS + offset;
+		prefix = &COLONS[offset];
 
 		/* Show the modes */
 		for (i = 0; i < num_parent; i++) {
-- 
1.8.1

  reply	other threads:[~2013-01-17 11:24 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-16 14:53 [PATCH] fix some clang warnings Max Horn
2013-01-16 16:04 ` Jeff King
2013-01-16 16:53   ` Junio C Hamano
2013-01-16 17:12     ` Antoine Pelisse
2013-01-16 17:18       ` John Keeping
2013-01-16 17:26         ` Max Horn
2013-01-16 17:50           ` Jeff King
2013-01-16 18:00             ` Jeff King
2013-01-16 18:09               ` Jeff King
2013-01-16 18:12               ` John Keeping
2013-01-16 18:15                 ` Jeff King
2013-01-16 18:21                   ` Antoine Pelisse
2013-01-16 18:22                   ` John Keeping
2013-01-16 18:24                     ` Jeff King
2013-01-16 19:01                       ` John Keeping
2013-01-17 10:24                         ` John Keeping
2013-01-16 22:47                       ` [PATCH 1/2] fix clang -Wconstant-conversion with bit fields Antoine Pelisse
2013-01-16 22:47                         ` [PATCH 2/2] fix clang -Wtautological-compare with unsigned enum Antoine Pelisse
2013-01-16 23:10                           ` Antoine Pelisse
2013-01-17 10:32                           ` Antoine Pelisse
2013-01-17 11:00                             ` John Keeping
2013-01-17 11:23                               ` John Keeping [this message]
2013-01-17 16:44                               ` Linus Torvalds
2013-01-17 16:56                                 ` Antoine Pelisse
2013-01-17 17:02                                 ` John Keeping
2013-01-18 17:15                                 ` Phil Hord
2013-01-18 18:52                                   ` Linus Torvalds
2013-01-16 23:08                         ` [PATCH 1/2] fix clang -Wconstant-conversion with bit fields John Keeping
2013-01-16 23:09                           ` Antoine Pelisse
2013-01-16 23:15                             ` Antoine Pelisse
2013-01-16 23:43                         ` Junio C Hamano
2013-01-16 23:46                           ` Junio C Hamano
2013-01-16 18:03             ` [PATCH] fix some clang warnings Tomas Carnecky
2013-01-16 18:12             ` Matthieu Moy
2013-02-01  5:37             ` Miles Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130117112330.GE4574@serenity.lan \
    --to=john@keeping.me.uk \
    --cc=apelisse@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=j6t@kdbg.org \
    --cc=max@quendi.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).