From: John Keeping <john@keeping.me.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Pete Wyckoff <pw@padd.com>
Subject: Re: [PATCH v2] INSTALL: git-p4 doesn't support Python 3
Date: Sun, 20 Jan 2013 19:28:31 +0000 [thread overview]
Message-ID: <20130120192831.GB7498@serenity.lan> (raw)
In-Reply-To: <7vwqv7lm6b.fsf@alter.siamese.dyndns.org>
On Sun, Jan 20, 2013 at 10:54:52AM -0800, Junio C Hamano wrote:
> John Keeping <john@keeping.me.uk> writes:
>
>> git-p4 supports Python 2.6 and later versions of Python 2. Since Python
>> 2.8 will never exist [1], it is most concise to just list the supported
>> versions.
>
> Thanks; Eric's patch recently updated git-p4.py to require 2.4 I
> think. Shouldn't it also be updated?
I haven't done a thorough audit to check what the actual minimum
supported version is, this is just the minimal change to say "not
Python 3".
Personally, I'm not sure of the value of having version checks at the
top of the Python scripts, I would rather set a project-wide minimum
supported version (as in my recent CodingGuidelines patch) and check it
once in the Makefile.
John
next prev parent reply other threads:[~2013-01-20 19:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 11:06 [PATCH v2] INSTALL: git-p4 doesn't support Python 3 John Keeping
2013-01-20 18:54 ` Junio C Hamano
2013-01-20 19:28 ` John Keeping [this message]
2013-01-20 19:54 ` Junio C Hamano
2013-01-20 21:03 ` Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130120192831.GB7498@serenity.lan \
--to=john@keeping.me.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pw@padd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).