git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Keeping <john@keeping.me.uk>
To: git@vger.kernel.org
Cc: "Eric S. Raymond" <esr@thyrsus.com>
Subject: git-cvsimport-3 and incremental imports
Date: Sun, 20 Jan 2013 20:09:22 +0000	[thread overview]
Message-ID: <20130120200922.GC7498@serenity.lan> (raw)

I've now spent some time looking at git-cvsimport-3.py from
jc/cvsimport-upgrade and made some progress in making it pass more of
the Git test suite (my work in progress is at [1]).

However, I think there is a fundamental problem with the way it handles
incremental imports and I'm hoping someone with more git-fast-import
experience can point me in the right direction.

Currently, cvsps-3 never writes a "from ..." line in the first commit it
outputs for a branch, even when the output is restricted by date (i.e. a
continuation of a previously imported branch), which results in failure
to update branches since git-fast-import is run without "--force".  If I
make a simple modification so that it does this, it can end up
outputting an empty commit (a duplicate of the current tip commit on the
branch).

Given that the start date for the import is currently just read from
HEAD there is probably scope for this being worse on other branches if
they have more recent commits than the current branch.

I don't think there is any way to solve this without giving cvsps more
information, probably the last commit time for all git branches, but
perhaps I'm missing a fast-import feature that can help solve this
problem.


[1] https://github.com/johnkeeping/git/tree/cvsimport-3


John

             reply	other threads:[~2013-01-20 20:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-20 20:09 John Keeping [this message]
2013-01-20 23:20 ` git-cvsimport-3 and incremental imports Eric S. Raymond
2013-01-20 23:34   ` Jonathan Nieder
2013-01-21  0:01     ` Junio C Hamano
2013-01-21  0:06       ` Junio C Hamano
2013-01-20 23:42   ` Jonathan Nieder
2013-01-21  1:06     ` Eric S. Raymond
2013-01-21  6:42       ` Jonathan Nieder
2013-01-21  7:28       ` Junio C Hamano
2013-01-21  7:35         ` Junio C Hamano
2013-01-21  9:36   ` John Keeping
2013-01-21 11:28     ` Eric S. Raymond
2013-01-21 12:00       ` John Keeping
2013-01-21 12:43         ` Eric S. Raymond
2013-01-21 13:27           ` John Keeping
2013-01-21 14:07             ` Eric S. Raymond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130120200922.GC7498@serenity.lan \
    --to=john@keeping.me.uk \
    --cc=esr@thyrsus.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).