From: John Keeping <john@keeping.me.uk>
To: "Eric S. Raymond" <esr@thyrsus.com>
Cc: git@vger.kernel.org
Subject: Re: git-cvsimport-3 and incremental imports
Date: Mon, 21 Jan 2013 13:27:06 +0000 [thread overview]
Message-ID: <20130121132706.GF7498@serenity.lan> (raw)
In-Reply-To: <20130121124340.GA32219@thyrsus.com>
On Mon, Jan 21, 2013 at 07:43:40AM -0500, Eric S. Raymond wrote:
> John Keeping <john@keeping.me.uk>:
>> I also disagree that cvsps outputs commits *newer* than T since it will
>> also output commits *at* T, which is what I changed with the patch in my
>> previous message.
>
> Ah. OK, that is yet another bug inherited from 2.x - the code doesn't
> match the documented (and correct) behavior. Please send me a patch
> against the cvsps repo, I'll merge it.
Should now be in your inbox.
> > Perhaps it is simplest to just save a CVS_LAST_IMPORT_TIME file in
> > $GIT_DIR and not worry about it any more.
>
> Yes, I think you're right. Trying to carry that information in-band would
> probably doom us to all sorts of bug-prone complications.
I think the only way to do it without needing to save local state in the
Git repository would be to teach cvsps to read a table of refs and times
from its stdin so that we could do something like:
git for-each-ref --format='%(refname)%09%(*authordate:raw)' refs/heads/ |
cvsps -i --branch-times-from-stdin |
git fast-import
Then cvsps could create a hash table from this and use that to decide
whether a patch set is interesting or not.
John
next prev parent reply other threads:[~2013-01-21 13:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-20 20:09 git-cvsimport-3 and incremental imports John Keeping
2013-01-20 23:20 ` Eric S. Raymond
2013-01-20 23:34 ` Jonathan Nieder
2013-01-21 0:01 ` Junio C Hamano
2013-01-21 0:06 ` Junio C Hamano
2013-01-20 23:42 ` Jonathan Nieder
2013-01-21 1:06 ` Eric S. Raymond
2013-01-21 6:42 ` Jonathan Nieder
2013-01-21 7:28 ` Junio C Hamano
2013-01-21 7:35 ` Junio C Hamano
2013-01-21 9:36 ` John Keeping
2013-01-21 11:28 ` Eric S. Raymond
2013-01-21 12:00 ` John Keeping
2013-01-21 12:43 ` Eric S. Raymond
2013-01-21 13:27 ` John Keeping [this message]
2013-01-21 14:07 ` Eric S. Raymond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130121132706.GF7498@serenity.lan \
--to=john@keeping.me.uk \
--cc=esr@thyrsus.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).