From: Jeff King <peff@peff.net>
To: Armin <netzverweigerer@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: segmentation fault (nullpointer) with git log --submodule -p
Date: Wed, 23 Jan 2013 15:02:22 -0500 [thread overview]
Message-ID: <20130123200222.GB19832@sigill.intra.peff.net> (raw)
In-Reply-To: <20130123143816.GA579@krypton.darkbyte.org>
On Wed, Jan 23, 2013 at 03:38:16PM +0100, Armin wrote:
> Hello dear git people.
>
> I experience a reproducible segmentation fault on one of my
> repositories when doing a "git log --submodule -p", tested with newest
> version on Arch Linux (git version 1.8.1.1) and built fresh (git
> version 1.8.1.1.347.g9591fcc), tried on 2 seperate systems:
>
>
> Program terminated with signal 11, Segmentation fault.
> #0 0x00000000004b51e5 in parse_commit_header (context=0x7ffff69b6980) at pretty.c:752
> 752 for (i = 0; msg[i]; i++) {
> [...]
> (gdb) l
> 747 static void parse_commit_header(struct format_commit_context *context)
> 748 {
> 749 const char *msg = context->message;
> 750 int i;
> 751
> 752 for (i = 0; msg[i]; i++) {
> 753 int eol;
> 754 for (eol = i; msg[eol] && msg[eol] != '\n'; eol++)
> 755 ; /* do nothing */
> 756
> (gdb) p msg
> $7 = <optimized out>
> (gdb) p context->message
> $8 = 0x0
Yeah, that should definitely not be NULL. I can't reproduce here with a
few simple examples, though.
Does it fail with older versions of git? If so, can you bisect?
Is it possible for you to make your repo available?
-Peff
next prev parent reply other threads:[~2013-01-23 20:02 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 14:38 segmentation fault (nullpointer) with git log --submodule -p Armin
2013-01-23 20:02 ` Jeff King [this message]
2013-01-24 12:11 ` Stefan Näwe
2013-01-24 13:40 ` Duy Nguyen
2013-01-24 14:06 ` Stefan Näwe
2013-01-24 14:14 ` Duy Nguyen
2013-01-24 23:27 ` Jeff King
2013-01-24 23:56 ` Junio C Hamano
2013-01-25 0:55 ` Jeff King
2013-01-25 2:05 ` Duy Nguyen
2013-01-25 3:59 ` Junio C Hamano
2013-01-25 4:08 ` Jeff King
2013-01-25 4:21 ` Junio C Hamano
2013-01-25 5:53 ` Jonathan Nieder
2013-01-25 7:27 ` Junio C Hamano
2013-01-25 7:32 ` Jonathon Mah
2013-01-25 15:36 ` Junio C Hamano
2013-01-26 9:40 ` [PATCH 0/3] lazily load commit->buffer Jeff King
2013-01-26 9:42 ` [PATCH 1/3] commit: drop useless xstrdup of commit message Jeff King
2013-01-26 9:44 ` [PATCH 2/3] logmsg_reencode: never return NULL Jeff King
2013-01-26 9:44 ` [PATCH 3/3] logmsg_reencode: lazily load missing commit buffers Jeff King
2013-01-26 21:26 ` [PATCH 0/3] lazily load commit->buffer Junio C Hamano
2013-01-26 22:14 ` Jeff King
2013-01-27 5:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130123200222.GB19832@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=netzverweigerer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).