* [PATCH] git-svn: cleanup sprintf usage for uppercasing hex
@ 2013-01-24 1:28 Eric Wong
2013-01-24 1:32 ` [PULL] git-svn updates for master Eric Wong
2013-01-24 1:33 ` [PATCH] git-svn: cleanup sprintf usage for uppercasing hex Jonathan Nieder
0 siblings, 2 replies; 4+ messages in thread
From: Eric Wong @ 2013-01-24 1:28 UTC (permalink / raw)
To: git; +Cc: Junio C Hamano
We do not need to call uc() separately for sprintf("%x")
as sprintf("%X") is available.
Signed-off-by: Eric Wong <normalperson@yhbt.net>
---
perl/Git/SVN.pm | 4 ++--
perl/Git/SVN/Editor.pm | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm
index 59215fa..490e330 100644
--- a/perl/Git/SVN.pm
+++ b/perl/Git/SVN.pm
@@ -490,7 +490,7 @@ sub refname {
#
# Additionally, % must be escaped because it is used for escaping
# and we want our escaped refname to be reversible
- $refname =~ s{([ \%~\^:\?\*\[\t])}{uc sprintf('%%%02x',ord($1))}eg;
+ $refname =~ s{([ \%~\^:\?\*\[\t])}{sprintf('%%%02X',ord($1))}eg;
# no slash-separated component can begin with a dot .
# /.* becomes /%2E*
@@ -2377,7 +2377,7 @@ sub map_path {
sub uri_encode {
my ($f) = @_;
- $f =~ s#([^a-zA-Z0-9\*!\:_\./\-])#uc sprintf("%%%02x",ord($1))#eg;
+ $f =~ s#([^a-zA-Z0-9\*!\:_\./\-])#sprintf("%%%02X",ord($1))#eg;
$f
}
diff --git a/perl/Git/SVN/Editor.pm b/perl/Git/SVN/Editor.pm
index 3db1521..fa0d3c6 100644
--- a/perl/Git/SVN/Editor.pm
+++ b/perl/Git/SVN/Editor.pm
@@ -146,7 +146,7 @@ sub url_path {
my ($self, $path) = @_;
if ($self->{url} =~ m#^https?://#) {
# characters are taken from subversion/libsvn_subr/path.c
- $path =~ s#([^~a-zA-Z0-9_./!$&'()*+,-])#uc sprintf("%%%02x",ord($1))#eg;
+ $path =~ s#([^~a-zA-Z0-9_./!$&'()*+,-])#sprintf("%%%02X",ord($1))#eg;
}
$self->{url} . '/' . $self->repo_path($path);
}
--
Eric Wong
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PULL] git-svn updates for master
2013-01-24 1:28 [PATCH] git-svn: cleanup sprintf usage for uppercasing hex Eric Wong
@ 2013-01-24 1:32 ` Eric Wong
2013-01-24 10:25 ` [PULL (updated)] " Eric Wong
2013-01-24 1:33 ` [PATCH] git-svn: cleanup sprintf usage for uppercasing hex Jonathan Nieder
1 sibling, 1 reply; 4+ messages in thread
From: Eric Wong @ 2013-01-24 1:32 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Barry Wardell
The following changes since commit ec3ae6ec46ed48383ae40643990f169b65a563cc:
Merge git://ozlabs.org/~paulus/gitk (2013-01-23 08:35:03 -0800)
are available in the git repository at:
git://bogomips.org/git-svn master
for you to fetch changes up to 812ed405ac961093b7eb916246d5f288630edfb2:
git-svn: cleanup sprintf usage for uppercasing hex (2013-01-24 01:30:04 +0000)
----------------------------------------------------------------
Barry Wardell (1):
git-svn: Simplify calculation of GIT_DIR
Eric Wong (1):
git-svn: cleanup sprintf usage for uppercasing hex
git-svn.perl | 38 +++++++++++++++-----------------------
perl/Git/SVN.pm | 4 ++--
perl/Git/SVN/Editor.pm | 2 +-
t/t9100-git-svn-basic.sh | 8 ++++++++
4 files changed, 26 insertions(+), 26 deletions(-)
--
Eric Wong
^ permalink raw reply [flat|nested] 4+ messages in thread* [PULL (updated)] git-svn updates for master
2013-01-24 1:32 ` [PULL] git-svn updates for master Eric Wong
@ 2013-01-24 10:25 ` Eric Wong
0 siblings, 0 replies; 4+ messages in thread
From: Eric Wong @ 2013-01-24 10:25 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git, Barry Wardell, Jonathan Nieder
I've squashed the change I mentioned in
http://mid.gmane.org/20130124101417.GA22138@dcvr.yhbt.net
to Barry's commit, and added Jonathan's Reviewed-by to my cleanup
commit.
The following changes since commit ec3ae6ec46ed48383ae40643990f169b65a563cc:
Merge git://ozlabs.org/~paulus/gitk (2013-01-23 08:35:03 -0800)
are available in the git repository at:
git://bogomips.org/git-svn for-junio
for you to fetch changes up to bc93ceb7c5ec959ad275f575a3c49ff491337a8b:
git-svn: Simplify calculation of GIT_DIR (2013-01-24 10:21:23 +0000)
(My old master is unchanged.)
----------------------------------------------------------------
Barry Wardell (1):
git-svn: Simplify calculation of GIT_DIR
Eric Wong (1):
git-svn: cleanup sprintf usage for uppercasing hex
git-svn.perl | 37 ++++++++++++++-----------------------
perl/Git/SVN.pm | 4 ++--
perl/Git/SVN/Editor.pm | 2 +-
t/t9100-git-svn-basic.sh | 8 ++++++++
4 files changed, 25 insertions(+), 26 deletions(-)
--
Eric Wong
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] git-svn: cleanup sprintf usage for uppercasing hex
2013-01-24 1:28 [PATCH] git-svn: cleanup sprintf usage for uppercasing hex Eric Wong
2013-01-24 1:32 ` [PULL] git-svn updates for master Eric Wong
@ 2013-01-24 1:33 ` Jonathan Nieder
1 sibling, 0 replies; 4+ messages in thread
From: Jonathan Nieder @ 2013-01-24 1:33 UTC (permalink / raw)
To: Eric Wong; +Cc: git, Junio C Hamano
Eric Wong wrote:
> We do not need to call uc() separately for sprintf("%x")
> as sprintf("%X") is available.
For what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-24 10:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-24 1:28 [PATCH] git-svn: cleanup sprintf usage for uppercasing hex Eric Wong
2013-01-24 1:32 ` [PULL] git-svn updates for master Eric Wong
2013-01-24 10:25 ` [PULL (updated)] " Eric Wong
2013-01-24 1:33 ` [PATCH] git-svn: cleanup sprintf usage for uppercasing hex Jonathan Nieder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).