From: Jonathan Nieder <jrnieder@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"Jean-Noël AVILA" <jn.avila@free.fr>,
git@vger.kernel.org,
"Daniel Baumann" <daniel.baumann@progress-technologies.net>
Subject: Re: [PATCH] t9902: protect test from stray build artifacts
Date: Thu, 24 Jan 2013 18:59:10 -0800 [thread overview]
Message-ID: <20130125025910.GB26524@elie.Belkin> (raw)
In-Reply-To: <20130125011349.GB27657@sigill.intra.peff.net>
Jeff King wrote:
> On Thu, Jan 24, 2013 at 03:07:42PM -0800, Junio C Hamano wrote[1]:
>> Instrument the completion script and give it a way for us to tell
>> what (subset of) subcommands we are going to ship.
[...]
> The only thing I might add is a test just to double-check that "git help
> -a" is parsed correctly. Like:
>
> test_expect_success 'command completion works without test harness' '
> GIT_TESTING_COMMAND_COMPLETION= run_completion "git bun" &&
> grep "^bundle\$" out
> '
Yes. Since there are no other 'git help -a' tests, I think we need
this.
Aside from that, the fix looks good to me.
Jonathan
[1] http://thread.gmane.org/gmane.comp.version-control.git/214167/focus=214469
next prev parent reply other threads:[~2013-01-25 2:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-21 22:30 [RFC] Instruct git-completion.bash that we are in test mode Jean-Noël AVILA
2013-01-21 23:32 ` Junio C Hamano
2013-01-22 0:39 ` Jeff King
2013-01-22 4:31 ` Junio C Hamano
2013-01-22 8:04 ` Jean-Noël Avila
2013-01-22 16:31 ` Junio C Hamano
2013-01-24 23:07 ` [PATCH] t9902: protect test from stray build artifacts Junio C Hamano
2013-01-25 1:13 ` Jeff King
2013-01-25 2:59 ` Jonathan Nieder [this message]
2013-01-25 4:11 ` Junio C Hamano
2013-01-25 4:13 ` Jeff King
2013-01-25 4:19 ` Junio C Hamano
2013-01-25 4:23 ` Jeff King
2013-01-25 18:34 ` Junio C Hamano
2013-01-25 22:06 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125025910.GB26524@elie.Belkin \
--to=jrnieder@gmail.com \
--cc=daniel.baumann@progress-technologies.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jn.avila@free.fr \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).