From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Keeping Subject: Re: [PATCH] git-remote-testpy: fix patch hashing on Python 3 Date: Sun, 27 Jan 2013 20:21:06 +0000 Message-ID: <20130127202106.GU7498@serenity.lan> References: <611a44568bdc969bcfa3d7d870560855e00baf1e.1358686905.git.john@keeping.me.uk> <20130126175158.GK7498@serenity.lan> <7vwquzzkiw.fsf@alter.siamese.dyndns.org> <5104B0B5.1030501@alum.mit.edu> <20130127141329.GN7498@serenity.lan> <20130127145056.GP7498@serenity.lan> <7vzjzuv224.fsf@alter.siamese.dyndns.org> <20130127200401.GT7498@serenity.lan> <7vr4l6v11z.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Michael Haggerty , git@vger.kernel.org, Sverre Rabbelier To: Junio C Hamano X-From: git-owner@vger.kernel.org Sun Jan 27 21:21:41 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TzYjR-0000n9-MJ for gcvg-git-2@plane.gmane.org; Sun, 27 Jan 2013 21:21:38 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756036Ab3A0UVQ (ORCPT ); Sun, 27 Jan 2013 15:21:16 -0500 Received: from coyote.aluminati.org ([72.9.247.114]:47489 "EHLO coyote.aluminati.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755932Ab3A0UVP (ORCPT ); Sun, 27 Jan 2013 15:21:15 -0500 Received: from localhost (localhost [127.0.0.1]) by coyote.aluminati.org (Postfix) with ESMTP id B1EB46064DD; Sun, 27 Jan 2013 20:21:14 +0000 (GMT) X-Virus-Scanned: Debian amavisd-new at caracal.aluminati.org X-Spam-Flag: NO X-Spam-Score: -11 X-Spam-Level: X-Spam-Status: No, score=-11 tagged_above=-9999 required=6.31 tests=[ALL_TRUSTED=-1, ALUMINATI_LOCAL_TESTS=-10] autolearn=ham Received: from coyote.aluminati.org ([127.0.0.1]) by localhost (coyote.aluminati.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ODnAHlzLkJJs; Sun, 27 Jan 2013 20:21:14 +0000 (GMT) Received: from pichi.aluminati.org (pichi.aluminati.org [10.0.16.50]) by coyote.aluminati.org (Postfix) with ESMTP id 50F0E6064D7; Sun, 27 Jan 2013 20:21:14 +0000 (GMT) Received: from localhost (localhost [127.0.0.1]) by pichi.aluminati.org (Postfix) with ESMTP id 43212161E54F; Sun, 27 Jan 2013 20:21:14 +0000 (GMT) X-Virus-Scanned: Debian amavisd-new at aluminati.org Received: from pichi.aluminati.org ([127.0.0.1]) by localhost (pichi.aluminati.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XFExDI3TD8MV; Sun, 27 Jan 2013 20:21:14 +0000 (GMT) Received: from serenity.lan (tg2.aluminati.org [10.0.7.178]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pichi.aluminati.org (Postfix) with ESMTPSA id 53FE4161E02E; Sun, 27 Jan 2013 20:21:07 +0000 (GMT) Content-Disposition: inline In-Reply-To: <7vr4l6v11z.fsf@alter.siamese.dyndns.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On Sun, Jan 27, 2013 at 12:11:20PM -0800, Junio C Hamano wrote: > John Keeping writes: > > >> Thanks; will queue and wait for an Ack from Michael. > >> > >> Does the helper function need to be named with leading underscore, > >> though? > > > > ... Since this is a script > > not a library module I don't feel strongly about it in this case. > > That is exactly why I asked. So I think the answer is "habit, but I probably shouldn't have put it in in this case". John