From: Jeff King <peff@peff.net>
To: Shawn Pearce <spearce@spearce.org>
Cc: Junio C Hamano <gitster@pobox.com>, git <git@vger.kernel.org>,
git-dev@github.com
Subject: Re: [PATCH 1/2] upload-pack: avoid parsing objects during ref advertisement
Date: Tue, 29 Jan 2013 03:14:10 -0500 [thread overview]
Message-ID: <20130129081409.GA5350@sigill.intra.peff.net> (raw)
In-Reply-To: <CAJo=hJubUF2mmkzXU77kQ5uj1cbBZrnLcw2u736wMqxhs39jdQ@mail.gmail.com>
On Tue, Jan 29, 2013 at 12:10:59AM -0800, Shawn O. Pearce wrote:
> > On a repository with 120K refs, the advertisement portion of
> > upload-pack goes from ~3.4s to 3.2s (the failure to speed up
> > more is largely due to the fact that most of these refs are
> > tags, which need dereferenced to find the tag destination
> > anyway).
>
> Why aren't we using the peeled information from the packed-refs file?
> JGit does this and it saves a lot of time on advertisements from a
> well packed repository.
The patch you are replying to is a year old. Since then, I did:
435c833 (upload-pack: use peel_ref for ref advertisements, 2012-10-04)
-Peff
next prev parent reply other threads:[~2013-01-29 8:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-05 21:00 [PATCH] parse_object: try internal cache before reading object db Jeff King
2012-01-05 21:35 ` Junio C Hamano
2012-01-05 21:49 ` Jeff King
2012-01-05 21:55 ` Junio C Hamano
2012-01-05 22:18 ` Jeff King
2012-01-06 19:16 ` Jeff King
2012-01-06 21:27 ` Junio C Hamano
2012-01-06 22:33 ` Jeff King
2012-01-06 22:45 ` Junio C Hamano
2012-01-06 22:46 ` Jeff King
2012-01-06 19:17 ` [PATCH 1/2] upload-pack: avoid parsing objects during ref advertisement Jeff King
2013-01-18 23:12 ` Junio C Hamano
2013-01-24 7:50 ` Jeff King
2013-01-24 17:25 ` Junio C Hamano
2013-01-29 8:10 ` Shawn Pearce
2013-01-29 8:14 ` Jeff King [this message]
2012-01-06 19:18 ` [PATCH 2/2] upload-pack: avoid parsing tag destinations Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129081409.GA5350@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git-dev@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).