From: John Keeping <john@keeping.me.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git_remote_helpers: remove GIT-PYTHON-VERSION upon "clean"
Date: Wed, 30 Jan 2013 20:03:56 +0000 [thread overview]
Message-ID: <20130130200356.GL1342@serenity.lan> (raw)
In-Reply-To: <7vzjzqjwot.fsf@alter.siamese.dyndns.org>
On Wed, Jan 30, 2013 at 11:30:10AM -0800, Junio C Hamano wrote:
> fadf8c7 (git_remote_helpers: force rebuild if python version changes, 2013-01-20)
> started using a marker file to keep track of the version of Python interpreter
> used for the last build, but forgot to remove it when asked to "make clean".
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Looks obviously correct to me. Sorry for missing this at the time.
FWIW:
Reviewed-by: John Keeping <john@keeping.me.uk>
> ---
> git_remote_helpers/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git_remote_helpers/Makefile b/git_remote_helpers/Makefile
> index 0d2ae74..3d12232 100644
> --- a/git_remote_helpers/Makefile
> +++ b/git_remote_helpers/Makefile
> @@ -42,4 +42,4 @@ instlibdir: $(pysetupfile)
>
> clean:
> $(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) clean -a
> - $(RM) *.pyo *.pyc
> + $(RM) *.pyo *.pyc GIT-PYTHON-VERSION
prev parent reply other threads:[~2013-01-30 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-30 19:30 [PATCH] git_remote_helpers: remove GIT-PYTHON-VERSION upon "clean" Junio C Hamano
2013-01-30 20:03 ` John Keeping [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130200356.GL1342@serenity.lan \
--to=john@keeping.me.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).