* [PATCH] git_remote_helpers: remove GIT-PYTHON-VERSION upon "clean"
@ 2013-01-30 19:30 Junio C Hamano
2013-01-30 20:03 ` John Keeping
0 siblings, 1 reply; 2+ messages in thread
From: Junio C Hamano @ 2013-01-30 19:30 UTC (permalink / raw)
To: git; +Cc: John Keeping
fadf8c7 (git_remote_helpers: force rebuild if python version changes, 2013-01-20)
started using a marker file to keep track of the version of Python interpreter
used for the last build, but forgot to remove it when asked to "make clean".
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
git_remote_helpers/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/git_remote_helpers/Makefile b/git_remote_helpers/Makefile
index 0d2ae74..3d12232 100644
--- a/git_remote_helpers/Makefile
+++ b/git_remote_helpers/Makefile
@@ -42,4 +42,4 @@ instlibdir: $(pysetupfile)
clean:
$(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) clean -a
- $(RM) *.pyo *.pyc
+ $(RM) *.pyo *.pyc GIT-PYTHON-VERSION
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] git_remote_helpers: remove GIT-PYTHON-VERSION upon "clean"
2013-01-30 19:30 [PATCH] git_remote_helpers: remove GIT-PYTHON-VERSION upon "clean" Junio C Hamano
@ 2013-01-30 20:03 ` John Keeping
0 siblings, 0 replies; 2+ messages in thread
From: John Keeping @ 2013-01-30 20:03 UTC (permalink / raw)
To: Junio C Hamano; +Cc: git
On Wed, Jan 30, 2013 at 11:30:10AM -0800, Junio C Hamano wrote:
> fadf8c7 (git_remote_helpers: force rebuild if python version changes, 2013-01-20)
> started using a marker file to keep track of the version of Python interpreter
> used for the last build, but forgot to remove it when asked to "make clean".
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Looks obviously correct to me. Sorry for missing this at the time.
FWIW:
Reviewed-by: John Keeping <john@keeping.me.uk>
> ---
> git_remote_helpers/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git_remote_helpers/Makefile b/git_remote_helpers/Makefile
> index 0d2ae74..3d12232 100644
> --- a/git_remote_helpers/Makefile
> +++ b/git_remote_helpers/Makefile
> @@ -42,4 +42,4 @@ instlibdir: $(pysetupfile)
>
> clean:
> $(QUIET)$(PYTHON_PATH) $(pysetupfile) $(QUIETSETUP) clean -a
> - $(RM) *.pyo *.pyc
> + $(RM) *.pyo *.pyc GIT-PYTHON-VERSION
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-30 20:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-30 19:30 [PATCH] git_remote_helpers: remove GIT-PYTHON-VERSION upon "clean" Junio C Hamano
2013-01-30 20:03 ` John Keeping
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).