From: Jeff King <peff@peff.net>
To: Antoine Pelisse <apelisse@gmail.com>
Cc: Jongman Heo <jongman.heo@samsung.com>, git <git@vger.kernel.org>
Subject: Re: Segmentation fault with latest git (070c57df)
Date: Thu, 31 Jan 2013 02:35:43 -0500 [thread overview]
Message-ID: <20130131073543.GA5342@sigill.intra.peff.net> (raw)
In-Reply-To: <CALWbr2y8veWYRwEGrbGq-PhxZjXbBF5HMgQXrRr=1JzGQ9Y-tQ@mail.gmail.com>
On Thu, Jan 31, 2013 at 08:02:06AM +0100, Antoine Pelisse wrote:
> In "clean.c" we have a "string_list" created on the stack with
> "STRING_LIST_INIT_NODUP" (there are probably others, I stopped at the
> first occurrence).
> But, "STRING_LIST_INIT_NODUP" doesn't init the "list->cmp" pointer
> which can thus be random.
I don't think that is the problem. Extra struct members that are not
mentioned by an initializer will get set to 0 or NULL.
A code path that tried to initialize each member individually would run
into problems, but I could not find any such code path (all of them
either use an initializer, are static, or memset the struct to
all-zeroes).
-Peff
next prev parent reply other threads:[~2013-01-31 7:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 1:35 Segmentation fault with latest git (070c57df) Jongman Heo
2013-01-31 6:49 ` Jeff King
2013-01-31 7:02 ` Antoine Pelisse
2013-01-31 7:35 ` Jeff King [this message]
2013-02-04 6:58 ` Jongman Heo
2013-02-04 7:13 ` Junio C Hamano
2013-02-04 8:37 ` Jeff King
2013-02-04 9:16 ` Junio C Hamano
2013-02-04 9:29 ` Junio C Hamano
2013-02-04 9:45 ` Jeff King
2013-02-04 9:38 ` Jeff King
2013-02-04 16:46 ` Junio C Hamano
2013-02-04 18:34 ` Jonathan Nieder
2013-05-15 3:14 ` sam
2013-05-15 3:22 ` sam
2013-05-16 13:12 ` Ramkumar Ramachandra
2013-05-16 13:21 ` Ramkumar Ramachandra
-- strict thread matches above, loose matches on Subject: below --
2013-01-31 7:27 Jongman Heo
2013-01-31 7:55 ` Jeff King
2013-01-31 8:42 ` Thomas Rast
2013-01-31 8:54 ` Jeff King
2013-02-01 1:31 허종만
2013-02-01 1:40 ` Junio C Hamano
2013-02-01 6:36 ` Jeff King
2013-02-01 7:06 ` Jeff King
2013-02-01 7:09 ` Jeff King
2013-02-04 2:18 Re: Re: Re: " Jongman Heo
2013-02-04 3:40 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130131073543.GA5342@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=apelisse@gmail.com \
--cc=git@vger.kernel.org \
--cc=jongman.heo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).