From: Jeff King <peff@peff.net>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCHv2 1/3] gpg: Close stderr once finished with it in verify_signed_buffer()
Date: Thu, 31 Jan 2013 17:37:10 -0500 [thread overview]
Message-ID: <20130131223710.GD21729@sigill.intra.peff.net> (raw)
In-Reply-To: <1359656320-4434-1-git-send-email-sboyd@codeaurora.org>
On Thu, Jan 31, 2013 at 10:18:40AM -0800, Stephen Boyd wrote:
> Failing to close the stderr pipe in verify_signed_buffer() causes
> git to run out of file descriptors if there are many calls to
> verify_signed_buffer(). An easy way to trigger this is to run
>
> git log --show-signature --merges | grep "key"
>
> on the linux kernel git repo. Eventually it will fail with
>
> error: cannot create pipe for gpg: Too many open files
> error: could not run gpg.
>
> Close the stderr pipe so that this can't happen.
>
> Suggested-by: Jeff King <peff@peff.net>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Thanks, looks good to me (obviously :) ). The rest of the series looks
fine, too, with the caveat I mentioned on 2/3. Thanks for fixing this.
-Peff
next prev parent reply other threads:[~2013-01-31 22:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 2:01 [PATCH 0/3] GPG running out of pipes fixes Stephen Boyd
2013-01-31 2:01 ` [PATCH 1/3] gpg: Close stderr once finished with it in verify_signed_buffer() Stephen Boyd
2013-01-31 5:50 ` Jeff King
2013-01-31 18:06 ` Stephen Boyd
2013-01-31 18:18 ` [PATCHv2 " Stephen Boyd
2013-01-31 22:37 ` Jeff King [this message]
2013-01-31 2:01 ` [PATCH 2/3] run-command: Be more informative about what failed Stephen Boyd
2013-01-31 16:24 ` Junio C Hamano
2013-01-31 18:05 ` Stephen Boyd
2013-01-31 22:35 ` Jeff King
2013-01-31 23:57 ` Junio C Hamano
2013-01-31 2:01 ` [PATCH 3/3] gpg: Allow translation of more error messages Stephen Boyd
2013-01-31 18:20 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130131223710.GD21729@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).