From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: jongman.heo@samsung.com, Jonathan Nieder <jrnieder@gmail.com>,
Thomas Rast <trast@student.ethz.ch>, git <git@vger.kernel.org>,
Antoine Pelisse <apelisse@gmail.com>
Subject: Re: Segmentation fault with latest git (070c57df)
Date: Mon, 4 Feb 2013 03:37:01 -0500 [thread overview]
Message-ID: <20130204083701.GA30835@sigill.intra.peff.net> (raw)
In-Reply-To: <7vehgw5z7n.fsf@alter.siamese.dyndns.org>
On Sun, Feb 03, 2013 at 11:13:00PM -0800, Junio C Hamano wrote:
> Yeah, that result is understandable, as .depend/*.o.d files will not
> be rebuilt when the rules to build them changes in the Makefile.
> Applying the patch to the Makefile in the pristine old tree, run the
> build (which will generate .depend/*.o.d files with the corrected
> rules), then checking out the new tree and running the build again
> without "make clean", with or with the patch applied, would validate
> that the patch fixes the issue for old ccache.
>
> Thanks Jonathan for diagnosing, fixing, and thanks Jongman for
> testing.
Do we want to do anything with the other dependency hole I found here:
http://article.gmane.org/gmane.comp.version-control.git/215211
It's definitely a potential problem, but I don't think we have any
reports of it happening in practice, so it might not be worth worrying
about. Doing a clean version of the fix here:
http://article.gmane.org/gmane.comp.version-control.git/215212
would probably involve reorganizing our .depend directory structure,
unless somebody can cook up some clever use of make's patsubst.
-Peff
next prev parent reply other threads:[~2013-02-04 8:37 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 1:35 Segmentation fault with latest git (070c57df) Jongman Heo
2013-01-31 6:49 ` Jeff King
2013-01-31 7:02 ` Antoine Pelisse
2013-01-31 7:35 ` Jeff King
2013-02-04 6:58 ` Jongman Heo
2013-02-04 7:13 ` Junio C Hamano
2013-02-04 8:37 ` Jeff King [this message]
2013-02-04 9:16 ` Junio C Hamano
2013-02-04 9:29 ` Junio C Hamano
2013-02-04 9:45 ` Jeff King
2013-02-04 9:38 ` Jeff King
2013-02-04 16:46 ` Junio C Hamano
2013-02-04 18:34 ` Jonathan Nieder
2013-05-15 3:14 ` sam
2013-05-15 3:22 ` sam
2013-05-16 13:12 ` Ramkumar Ramachandra
2013-05-16 13:21 ` Ramkumar Ramachandra
-- strict thread matches above, loose matches on Subject: below --
2013-01-31 7:27 Jongman Heo
2013-01-31 7:55 ` Jeff King
2013-01-31 8:42 ` Thomas Rast
2013-01-31 8:54 ` Jeff King
2013-02-01 1:31 허종만
2013-02-01 1:40 ` Junio C Hamano
2013-02-01 6:36 ` Jeff King
2013-02-01 7:06 ` Jeff King
2013-02-01 7:09 ` Jeff King
2013-02-04 2:18 Re: Re: Re: " Jongman Heo
2013-02-04 3:40 ` Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130204083701.GA30835@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=apelisse@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jongman.heo@samsung.com \
--cc=jrnieder@gmail.com \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).