From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Michael Schubert <mschub@elegosoft.com>,
Shawn Pearce <spearce@spearce.org>,
git@vger.kernel.org
Subject: Re: [PATCH] Verify Content-Type from smart HTTP servers
Date: Wed, 6 Feb 2013 17:47:01 -0500 [thread overview]
Message-ID: <20130206224701.GH27507@sigill.intra.peff.net> (raw)
In-Reply-To: <7v4nhpo2qv.fsf@alter.siamese.dyndns.org>
On Wed, Feb 06, 2013 at 07:56:08AM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Is it worth having a strbuf_set* family of functions to match the
> > strbuf_add*? We seem to have these sorts of errors with strbuf from time
> > to time, and I wonder if that would make it easier (and more readable)
> > to do the right thing.
>
> Possibly.
>
> The callsite below may be a poor example, though; you would need the
> _reset() even if you change the _addstr() we can see in the context
> to _setstr() to make sure later strbuf_*(type) will start from a
> clean slate when !t anyway, no?
Ah, true. Let's not worry about it, then.
-Peff
next prev parent reply other threads:[~2013-02-06 22:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 22:09 [PATCH] Verify Content-Type from smart HTTP servers Junio C Hamano
2013-02-01 8:52 ` Jeff King
2013-02-01 18:09 ` Junio C Hamano
2013-02-01 18:58 ` Jeff King
2013-02-04 7:17 ` Junio C Hamano
2013-02-04 8:38 ` Jeff King
2013-02-04 23:49 ` Shawn Pearce
2013-02-05 0:21 ` Junio C Hamano
2013-02-06 10:24 ` Michael Schubert
2013-02-06 10:39 ` Jeff King
2013-02-06 15:56 ` Junio C Hamano
2013-02-06 22:47 ` Jeff King [this message]
[not found] <1359666943-13316-1-git-send-email-spearce@spearce.org>
[not found] ` <7vd2wlf1zf.fsf@alter.siamese.dyndns.org>
2013-01-31 22:36 ` Shawn Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206224701.GH27507@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mschub@elegosoft.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).