From: John Keeping <john@keeping.me.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matt Kraai <kraai@ftbfs.org>,
git@vger.kernel.org, Max Horn <max@quendi.de>,
Jeff King <peff@peff.net>, Matt Kraai <matt.kraai@amo.abbott.com>
Subject: Re: [PATCH] Use __VA_ARGS__ for all of error's arguments
Date: Thu, 7 Feb 2013 21:14:49 +0000 [thread overview]
Message-ID: <20130207211449.GC1342@serenity.lan> (raw)
In-Reply-To: <7vwquj6dio.fsf@alter.siamese.dyndns.org>
On Thu, Feb 07, 2013 at 01:05:19PM -0800, Junio C Hamano wrote:
> Matt Kraai <kraai@ftbfs.org> writes:
>
> > -#if defined(__GNUC__) && ! defined(__clang__)
> > -#define error(fmt, ...) (error((fmt), ##__VA_ARGS__), -1)
> > -#endif
> > +#define error(...) (error(__VA_ARGS__), -1)
>
> Before your change, we only define error() macro for GCC variants,
> but with your patch that no longer is the case. Does every compiler
> that compiles Git correctly today support this style of varargs
> macros?
At the very least the "! defined(__clang__)" was only recently added
[1], although it shouldn't be needed once Clang 3.3 is released.
[1] http://article.gmane.org/gmane.comp.version-control.git/213787
John
next prev parent reply other threads:[~2013-02-07 21:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 20:00 [PATCH] Use __VA_ARGS__ for all of error's arguments Matt Kraai
2013-02-07 21:05 ` Junio C Hamano
2013-02-07 21:14 ` John Keeping [this message]
2013-02-07 21:24 ` Matt Kraai
2013-02-07 21:30 ` Matt Kraai
2013-02-08 4:24 ` Jeff King
2013-02-08 4:39 ` Matt Kraai
2013-02-08 15:09 ` Matt Kraai
2013-02-08 15:54 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130207211449.GC1342@serenity.lan \
--to=john@keeping.me.uk \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kraai@ftbfs.org \
--cc=matt.kraai@amo.abbott.com \
--cc=max@quendi.de \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).