git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ramkumar Ramachandra <artagnon@gmail.com>,
	Michael Schubert <mschub@elegosoft.com>,
	Git List <git@vger.kernel.org>
Subject: Re: Proposal: branch.<name>.remotepush
Date: Thu, 7 Feb 2013 23:48:13 -0800	[thread overview]
Message-ID: <20130208074813.GA7337@elie.Belkin> (raw)
In-Reply-To: <7v38x766b2.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> I'd actually see this as Gerrit being weird.
>
> If it wants to quarantine a commit destined to the "master" branch,
> couldn't it just let people push to "master" and then internally
> update "for/master" instead?

It is because pushing doesn't update refs/heads/master.  Instead, it
starts a code review.

Suppose Gerrit allows starting a new code review by pushing to
refs/heads/master.  It sounds okay if I squint --- it's just a very
slow asynchronous ref update, right?  Let's see:

	$ git clone <gerrit server> test
	Cloning into 'test'...
	$ echo hi >greeting
	$ git add greeting
	$ git commit -q -m 'hello'
	$ git push origin master
[...]
	remote: New Changes:
	remote:   <gerrit server>/r/1234
	remote: 
	To <url>
	   ea4cb77b..9117390e  master -> master
	$ : walk away, forget what I was doing
	$ git fetch origin
	From <url>
	 + 9117390...ea4cb77 master     -> origin/master  (forced update)

"Wait, why did the remote rewind?"

Regards,
Jonathan

  reply	other threads:[~2013-02-08  7:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-07 16:14 Proposal: branch.<name>.remotepush Ramkumar Ramachandra
2013-02-07 17:45 ` Michael Schubert
2013-02-07 19:37   ` Ramkumar Ramachandra
2013-02-07 19:49     ` Ramkumar Ramachandra
2013-02-07 20:14       ` Ramkumar Ramachandra
2013-02-07 23:30     ` Jonathan Nieder
2013-02-07 23:41       ` Junio C Hamano
2013-02-08  7:48         ` Jonathan Nieder [this message]
2013-02-08  8:16           ` Junio C Hamano
2013-02-08 10:38             ` Michael J Gruber
2013-02-08 17:11               ` Junio C Hamano
2013-02-08 17:16               ` Junio C Hamano
2013-02-08 18:29                 ` Ramkumar Ramachandra
2013-02-08 19:13                   ` Junio C Hamano
2013-02-08 18:36               ` Jonathan Nieder
2013-02-08 18:42       ` Ramkumar Ramachandra
2013-02-08 19:18         ` Junio C Hamano
2013-02-09  7:29           ` Ramkumar Ramachandra
2013-02-08  4:48 ` Jeff King
2013-02-08  6:08   ` Junio C Hamano
2013-02-08  6:28     ` Jeff King
2013-02-08  6:45     ` Junio C Hamano
2013-02-08  9:22       ` Jeff King
2013-02-08 17:06         ` Junio C Hamano
2013-02-08 18:03           ` Ramkumar Ramachandra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130208074813.GA7337@elie.Belkin \
    --to=jrnieder@gmail.com \
    --cc=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=mschub@elegosoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).