From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>,
git@vger.kernel.org, Dasa Paddock <dpaddock@esri.com>
Subject: Re: [PATCH] completion: support 'git config --local'
Date: Tue, 12 Feb 2013 19:05:19 -0500 [thread overview]
Message-ID: <20130213000519.GA31758@sigill.intra.peff.net> (raw)
In-Reply-To: <7v1uclfafi.fsf@alter.siamese.dyndns.org>
On Tue, Feb 12, 2013 at 02:13:05PM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > I'm not sure I understand the original poster's point about "git config
> > -l --local". "-l" does not take a limiter, does it?
>
> "git config -l core.\*" will just die without limiting the output to
> everything under core. hierarchy, so you are right---the combination
> does not make any sense. You have to say
>
> git config -l | grep ^core\\.
>
> or something like that.
>
> Completing "git config -l --lo<TAB>" still may help, though.
Ah, I think I see Dasa's original point now. He was interested in fixing
"--lo<TAB>" to complete "--local". But the line he pointed to in his
original message is not the right place for that; it is the site of an
unrelated spot which should _also_ be fixed to use "--local", but for a
different reason (restricting the variables suggested for "--local --get
<TAB>" properly).
So yeah. Matthieu's patch is the right thing to do, as it covers both
(mine fixed only half of it).
-Peff
next prev parent reply other threads:[~2013-02-13 0:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-09 18:37 git-completion.bash --local Dasa Paddock
2013-02-11 21:04 ` Jeff King
2013-02-12 5:49 ` [PATCH] completion: recognize "--local" as a config file source Jeff King
2013-02-12 12:20 ` [PATCH] completion: support 'git config --local' Matthieu Moy
2013-02-12 17:34 ` Junio C Hamano
2013-02-12 21:11 ` Jeff King
2013-02-12 22:13 ` Junio C Hamano
2013-02-13 0:05 ` Jeff King [this message]
2013-02-13 7:44 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213000519.GA31758@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@imag.fr \
--cc=dpaddock@esri.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).