From: XANi <xani666@gmail.com>
To: git@vger.kernel.org
Subject: [BUG] Veryfing signatures in git log fails when language is not english
Date: Thu, 14 Feb 2013 01:18:37 +0100 [thread overview]
Message-ID: <20130214011837.04880b3e@hydra.devrandom.pl> (raw)
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
Hi,
any functionality that depends on exact exit msg of program
can potentially fail because of that
ᛯ export |grep LANG
declare -x LANG="pl_PL.UTF-8"
ᛯ ~/src/os/git/git log --format="%G? %h" |head -2
0d19377
5b9d7f8
ᛯ unset LANG
ᛯ ~/src/os/git/git log --format="%G? %h" |head -2
G 0d19377
G 5b9d7f8
tested against maint (d32805d) and master (5bf72ed)
maybe git should set up some output-changing variables before calling
external programs? I think setting LC_ALL=C should be enougth.
--
Mariusz Gronczewski (XANi) <xani666@gmail.com>
GnuPG: 0xEA8ACE64
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next reply other threads:[~2013-02-14 0:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-14 0:18 XANi [this message]
2013-02-14 10:55 ` [BUG] Veryfing signatures in git log fails when language is not english Michael J Gruber
2013-02-14 12:42 ` Mariusz Gronczewski
2013-02-14 16:04 ` [PATCH 0/5] gpg_interface: use the status Michael J Gruber
2013-02-14 16:04 ` [PATCH 1/5] gpg-interface: check good signature in a reliable way Michael J Gruber
2013-02-14 17:22 ` Junio C Hamano
2013-02-15 8:27 ` Michael J Gruber
2013-02-14 16:04 ` [PATCH 2/5] log-tree: rely upon the check in the gpg_interface Michael J Gruber
2013-02-14 16:04 ` [PATCH 3/5] gpg_interface: allow to request status return Michael J Gruber
2013-02-14 16:04 ` [PATCH 4/5] pretty: parse the gpg status lines rather than the output Michael J Gruber
2013-02-14 16:04 ` [PATCH 5/5] pretty: make %GK output the signing key for signed commits Michael J Gruber
2013-02-14 16:47 ` [BUG] Veryfing signatures in git log fails when language is not english Junio C Hamano
2013-02-15 14:14 ` Mariusz Gronczewski
2013-02-15 16:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130214011837.04880b3e@hydra.devrandom.pl \
--to=xani666@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).