From: Pete Wyckoff <pw@padd.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Karsten Blees <karsten.blees@gmail.com>,
kusmabite@gmail.com, Ramkumar Ramachandra <artagnon@gmail.com>,
Robert Zeh <robert.allan.zeh@gmail.com>,
finnag@pvv.org
Subject: Re: [PATCH v2] read_directory: avoid invoking exclude machinery on tracked files
Date: Sat, 16 Feb 2013 13:11:10 -0500 [thread overview]
Message-ID: <20130216181110.GA27233@padd.com> (raw)
In-Reply-To: <1360999078-27196-1-git-send-email-pclouds@gmail.com>
pclouds@gmail.com wrote on Sat, 16 Feb 2013 14:17 +0700:
> Finally some numbers (best of 20 runs) that shows why it's worth all
> the hassle:
>
> git status | webkit linux-2.6 libreoffice-core gentoo-x86
> -------------+----------------------------------------------
> before | 1.097s 0.208s 0.399s 0.539s
> after | 0.736s 0.159s 0.248s 0.501s
> nr. patterns | 89 376 19 0
> nr. tracked | 182k 40k 63k 101k
Thanks for this work. I repeated some of the tests across NFS,
where I'd expect to see bigger differences. Best of 20 values
reported in "min ...".
webkit
Stock min 9.61 avg 11.61 +/- 1.35 max 14.26
Duy min 6.91 avg 7.67 +/- 0.46 max 8.71
linux
Stock min 2.27 avg 3.16 +/- 0.56 max 4.49
Duy min 2.04 avg 3.12 +/- 0.69 max 4.87
libreoffice-core
Stock min 4.56 avg 5.79 +/- 0.79 max 7.08
Duy min 3.96 avg 5.25 +/- 0.95 max 6.95
Similar 30%-ish speedup on webkit. And an absolute gain
of 2.7 seconds is quite nice.
-- Pete
next prev parent reply other threads:[~2013-02-16 18:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-15 14:17 [PATCH] read_directory: avoid invoking exclude machinery on tracked files Nguyễn Thái Ngọc Duy
2013-02-15 16:52 ` Junio C Hamano
2013-02-15 18:30 ` Duy Nguyen
2013-02-15 19:32 ` Junio C Hamano
2013-02-16 3:31 ` Duy Nguyen
2013-02-18 16:42 ` Karsten Blees
2013-02-16 7:17 ` [PATCH v2] " Nguyễn Thái Ngọc Duy
2013-02-16 18:11 ` Pete Wyckoff [this message]
2013-02-17 4:39 ` Duy Nguyen
2013-02-17 15:49 ` Pete Wyckoff
2013-02-17 23:18 ` Junio C Hamano
2013-02-25 22:01 ` [PATCH/RFC] dir.c: Make git-status --ignored even more consistent Karsten Blees
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130216181110.GA27233@padd.com \
--to=pw@padd.com \
--cc=artagnon@gmail.com \
--cc=finnag@pvv.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karsten.blees@gmail.com \
--cc=kusmabite@gmail.com \
--cc=pclouds@gmail.com \
--cc=robert.allan.zeh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).