From: Jonathan Nieder <jrnieder@gmail.com>
To: David Aguilar <davvid@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 4/4] t7800: "defaults" is no longer a builtin tool name
Date: Sun, 17 Feb 2013 03:23:34 -0800 [thread overview]
Message-ID: <20130217112334.GH6759@elie.Belkin> (raw)
In-Reply-To: <1360993666-81308-4-git-send-email-davvid@gmail.com>
David Aguilar wrote:
> t7800 tests that configured commands can override builtins,
> but this test was not adjusted when the "defaults" file was
> removed because the test continued to pass.
>
> Adjust the test to use the everlasting "vimdiff"
Heh. :)
> tool name
> instead of "defaults" so that it correctly tests against a tool
> that is known by mergetool--lib.
Makes sense. Thanks for a pleasant read.
Good night,
Jonathan
next prev parent reply other threads:[~2013-02-17 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-16 5:47 [PATCH 1/4] difftool: silence uninitialized variable warning David Aguilar
2013-02-16 5:47 ` [PATCH 2/4] t7800: Update copyright notice David Aguilar
2013-02-16 5:47 ` [PATCH 3/4] t7800: modernize tests David Aguilar
2013-02-16 5:47 ` [PATCH 4/4] t7800: "defaults" is no longer a builtin tool name David Aguilar
2013-02-17 11:23 ` Jonathan Nieder [this message]
2013-02-17 11:21 ` [PATCH 3/4] t7800: modernize tests Jonathan Nieder
2013-02-16 6:35 ` [PATCH 2/4] t7800: Update copyright notice David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130217112334.GH6759@elie.Belkin \
--to=jrnieder@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).