From: Jonathan Nieder <jrnieder@gmail.com>
To: martinerikwerner@gmail.com
Cc: s.oosthoek@xs4all.nl, git@vger.kernel.org,
trsten@science-computing.de, felipe.contreras@gmail.com
Subject: Re: [PATCH v2] shell-prompt: clean up nested if-then
Date: Mon, 18 Feb 2013 15:28:16 -0800 [thread overview]
Message-ID: <20130218232816.GE4022@elie.Belkin> (raw)
In-Reply-To: <5122b23b.512e980a.32b9.ffffa580@mx.google.com>
Martin Erik Werner wrote:
> Minor clean up of if-then nesting in checks for environment variables
> and config options. No functional changes.
>
> Signed-off-by: Martin Erik Werner <martinerikwerner@gmail.com>
> ---
> contrib/completion/git-prompt.sh | 27 +++++++++++++--------------
> 1 file changed, 13 insertions(+), 14 deletions(-)
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Thanks for the quick turnaround.
next prev parent reply other threads:[~2013-02-18 23:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1361204512.4758.10.camel@mas>
2013-02-18 16:23 ` [PATCH] shell-prompt: clean up nested if-then Martin Erik Werner
2013-02-18 19:10 ` Jonathan Nieder
[not found] ` <0c94f24b-f7ee-4699-87a7-6861b927cea4@email.android.com>
2013-02-18 22:56 ` Martin Erik Werner
2013-02-18 22:59 ` [PATCH v2] " martinerikwerner
2013-02-18 23:28 ` Jonathan Nieder [this message]
2013-02-18 23:07 ` [PATCH] " Junio C Hamano
2013-02-19 8:17 ` Simon Oosthoek
2013-02-19 16:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130218232816.GE4022@elie.Belkin \
--to=jrnieder@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=martinerikwerner@gmail.com \
--cc=s.oosthoek@xs4all.nl \
--cc=trsten@science-computing.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).