From: Jonathan Nieder <jrnieder@gmail.com>
To: Brandon Casey <drafnel@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/4] t/t7502: compare entire commit message with what was expected
Date: Mon, 18 Feb 2013 21:10:59 -0800 [thread overview]
Message-ID: <20130219051059.GD19757@elie.Belkin> (raw)
In-Reply-To: <20130219050813.GC19757@elie.Belkin>
Jonathan Nieder wrote:
> +++ w/t/t7502-commit.sh
[...]
> + # Please enter the commit message for your changes. Lines starting
> + # with '\''#'\'' will be kept; you may remove them yourself if you want to.
> + # An empty message aborts the commit.
> + #
> + # Author: A U Thor <author@example.com>
> + #
> + EOF
> + git commit -a --dry-run
> + } >expect &&
> + git commit --cleanup=verbatim -t template -a &&
> - git cat-file -p HEAD |sed -e "1,/^\$/d" |head -n 3 >actual &&
> + git cat-file -p HEAD |sed -e "1,/^\$/d" >actual &&
> test_cmp expect actual
Quick correction: this would use test_i18ncmp instead of test_cmp if
it ends up being a good idea.
next prev parent reply other threads:[~2013-02-19 5:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 4:17 [PATCH 1/4] t/t7502: compare entire commit message with what was expected Brandon Casey
2013-02-19 4:17 ` [PATCH 2/4] t7502: demonstrate breakage with a commit message with trailing newlines Brandon Casey
2013-02-19 5:39 ` Jonathan Nieder
2013-02-19 4:17 ` [PATCH 3/4] git-commit: only append a newline to -m mesg if necessary Brandon Casey
2013-02-19 6:31 ` Jonathan Nieder
2013-02-19 4:17 ` [PATCH 4/4] Documentation/git-commit.txt: correct a few minor grammatical mistakes Brandon Casey
2013-02-19 6:43 ` Jonathan Nieder
2013-02-19 7:18 ` Brandon Casey
2013-02-19 7:29 ` Jonathan Nieder
2013-02-19 17:33 ` Junio C Hamano
2013-02-19 18:14 ` [PATCH v2 4/4] Documentation/git-commit.txt: rework the --cleanup section Brandon Casey
2013-02-19 18:28 ` Brandon Casey
2013-02-19 18:29 ` Brandon Casey
2013-02-19 20:28 ` [PATCH] fixup! " Jonathan Nieder
2013-02-19 20:33 ` Brandon Casey
2013-02-19 20:35 ` [PATCH v2 4/4] " Junio C Hamano
2013-02-19 5:08 ` [PATCH 1/4] t/t7502: compare entire commit message with what was expected Jonathan Nieder
2013-02-19 5:10 ` Jonathan Nieder [this message]
2013-02-19 17:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130219051059.GD19757@elie.Belkin \
--to=jrnieder@gmail.com \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).