From: John Keeping <john@keeping.me.uk>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jiang Xin <worldhello.net@gmail.com>,
"Christoph J. Thompson" <cjsthompson@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH] Bugfix: undefined htmldir in config.mak.autogen
Date: Wed, 20 Feb 2013 09:42:41 +0000 [thread overview]
Message-ID: <20130220094240.GB5011@serenity.lan> (raw)
In-Reply-To: <7v4nh750v3.fsf@alter.siamese.dyndns.org>
On Tue, Feb 19, 2013 at 03:40:16PM -0800, Junio C Hamano wrote:
> I am not sure if such a layout can be actually used for installing,
> though. Didn't we see some issues around the relativeness of
> htmldir and mandir vs passing them down to Documentation/Makefile,
> or is it not an issue when ./configure and config.mak.autogen is
> used?
If these variables are set explicitly in config.mak.autogen (or indeed
config.mak) then these values should override the ones calculated in the
Makefiles so that we avoid that problem - the problem occurs if the
relative paths from the top-level Makefile are exported to
Documentation/Makefile.
John
prev parent reply other threads:[~2013-02-20 9:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 11:23 [PATCH] Bugfix: undefined htmldir in config.mak.autogen Jiang Xin
2013-02-19 19:11 ` Junio C Hamano
2013-02-19 22:59 ` Junio C Hamano
2013-02-19 23:40 ` Junio C Hamano
2013-02-20 1:39 ` Jiang Xin
2013-02-20 8:22 ` Stefano Lattarini
2013-02-20 10:42 ` Jiang Xin
2013-02-20 12:30 ` Stefano Lattarini
2013-02-20 9:42 ` John Keeping [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220094240.GB5011@serenity.lan \
--to=john@keeping.me.uk \
--cc=cjsthompson@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=worldhello.net@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).