From: Jeff King <peff@peff.net>
To: Joshua Clayton <stillcompiling@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Fix in Git.pm cat_blob crashes on large files
Date: Fri, 22 Feb 2013 10:38:01 -0500 [thread overview]
Message-ID: <20130222153801.GA15318@sigill.intra.peff.net> (raw)
In-Reply-To: <CAMB+bf+RyerXP3VP26KJM7wtVKOup15AeRpEewwKJx3=bL9+hQ@mail.gmail.com>
On Fri, Feb 22, 2013 at 07:11:54AM -0800, Joshua Clayton wrote:
> running git svn fetch on a remote repository (yes I know there are a
> lot of possible outside variables, including network latency)
> Code with 1024 reads and 64k writes:
>
> real 75m19.906s
> user 16m43.919s
> sys 29m16.326s
>
> Code with 1024 reads and 1024 writes:
>
> real 71m21.006s
> user 12m36.275s
> sys 24m26.112s
>
> ...so the simpler code wins the trivial test.
Interesting; I'd have expected no change or a slight win for your
version, which makes me wonder if the outside variables are dominating.
I wonder what 64K/64K would look like.
> I would say go with it.
> Should I resubmit?
Yes, please.
-Peff
prev parent reply other threads:[~2013-02-22 15:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 22:13 [PATCH] Fix in Git.pm cat_blob crashes on large files Joshua Clayton
2013-02-21 22:43 ` Jeff King
2013-02-21 23:18 ` Joshua Clayton
2013-02-21 23:24 ` Jeff King
2013-02-22 15:11 ` Joshua Clayton
2013-02-22 15:38 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130222153801.GA15318@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=stillcompiling@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).