From: Jeff King <peff@peff.net>
To: Joshua Clayton <stillcompiling@gmail.com>
Cc: git@vger.kernel.org, Erik Faye-Lund <kusmabite@gmail.com>
Subject: Re: [PATCH] Fix in Git.pm cat_blob crashes on large files (resubmit
Date: Fri, 22 Feb 2013 13:37:03 -0500 [thread overview]
Message-ID: <20130222183703.GC18934@sigill.intra.peff.net> (raw)
In-Reply-To: <CAMB+bfLvpKNLaEUyUUYsO5n2y+9tyd_QcnPVzX0s2Z2t3Fr9=g@mail.gmail.com>
On Fri, Feb 22, 2013 at 09:30:57AM -0800, Joshua Clayton wrote:
> Subject: Re: [PATCH] Fix in Git.pm cat_blob crashes on large files
> (resubmit with reviewed-by)
One thing I forgot to note in my other response: the subject is part of
the commit message, so information like "resubmit with..." should go
with other cover letter material after the "---".
It's also customary to say something like "PATCHv2" in the brackets
(which does get stripped off), and mention what is changed since v1
after the "---". That can help reviewers remember what happened, and it
can help the maintainer understand where in the process of review the
patch is.
-Peff
next prev parent reply other threads:[~2013-02-22 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 17:30 [PATCH] Fix in Git.pm cat_blob crashes on large files (resubmit with reviewed-by) Joshua Clayton
2013-02-22 18:34 ` Jeff King
2013-02-22 19:17 ` Joshua Clayton
2013-02-22 18:37 ` Jeff King [this message]
2013-02-22 18:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130222183703.GC18934@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=kusmabite@gmail.com \
--cc=stillcompiling@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).