From: Jonathan Nieder <jrnieder@gmail.com>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v2 3/2] update-index: list supported idx versions and their features
Date: Sat, 23 Feb 2013 12:55:14 -0800 [thread overview]
Message-ID: <20130223205514.GD3222@elie.Belkin> (raw)
In-Reply-To: <1361586571-12917-1-git-send-email-pclouds@gmail.com>
Nguyễn Thái Ngọc Duy wrote:
> Oops, bogus indentation in the first 3/2
Oops, I missed this. Ok, ignore the comment on indentation on v1. :)
With or without the other changes I suggested,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
next prev parent reply other threads:[~2013-02-23 20:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 12:09 [PATCH 1/2] index-format.txt: mention of v4 is missing in some places Nguyễn Thái Ngọc Duy
2013-02-22 12:09 ` [PATCH 2/2] read-cache.c: use INDEX_FORMAT_{LB,UB} in verify_hdr() Nguyễn Thái Ngọc Duy
2013-02-22 20:49 ` Junio C Hamano
2013-02-23 1:54 ` [PATCH 3/2] update-index: list supported idx versions and their features Nguyễn Thái Ngọc Duy
2013-02-23 20:53 ` Jonathan Nieder
2013-02-23 21:23 ` Junio C Hamano
2013-02-23 21:53 ` Jonathan Nieder
2013-02-23 2:29 ` [PATCH v2 " Nguyễn Thái Ngọc Duy
2013-02-23 20:55 ` Jonathan Nieder [this message]
2013-02-22 20:46 ` [PATCH 1/2] index-format.txt: mention of v4 is missing in some places Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130223205514.GD3222@elie.Belkin \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).