From: Jonathan Nieder <jrnieder@gmail.com>
To: David Aguilar <davvid@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 01/16] git-sh-setup: make usage text consistent
Date: Sat, 23 Feb 2013 16:25:09 -0800 [thread overview]
Message-ID: <20130224002509.GG3222@elie.Belkin> (raw)
In-Reply-To: <1361665254-42866-2-git-send-email-davvid@gmail.com>
David Aguilar wrote:
> mergetool, bisect, and other commands that use
> git-sh-setup print a usage string that is inconsistent
> with the rest of Git when they are invoked as "git $cmd -h".
>
> The compiled builtins use the lowercase "usage:" string
> but these commands say "Usage:". Adjust the shell library
> to make these consistent.
Scripts could be grepping for Usage:, but they are asking for
trouble and if anything should check for status 129 instead.
And luckily we have been careful about not checking for this
in tests. Thanks for the fix.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
next prev parent reply other threads:[~2013-02-24 0:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-24 0:20 [PATCH 00/16] make usage text consistent in git commands David Aguilar
2013-02-24 0:20 ` [PATCH 01/16] git-sh-setup: make usage text consistent David Aguilar
2013-02-24 0:20 ` [PATCH 02/16] git-svn: " David Aguilar
2013-02-24 0:20 ` [PATCH 03/16] git-relink: " David Aguilar
2013-02-24 0:20 ` [PATCH 04/16] git-merge-one-file: " David Aguilar
2013-02-24 0:20 ` [PATCH 05/16] git-archimport: " David Aguilar
2013-02-24 0:20 ` [PATCH 06/16] git-cvsexportcommit: " David Aguilar
2013-02-24 0:20 ` [PATCH 07/16] git-cvsimport: " David Aguilar
2013-02-24 0:20 ` [PATCH 08/16] " David Aguilar
2013-02-24 0:20 ` [PATCH 09/16] contrib/credential: " David Aguilar
2013-02-24 0:20 ` [PATCH 10/16] contrib/fast-import: " David Aguilar
2013-02-24 0:20 ` [PATCH 11/16] contrib/fast-import/import-zips.py: fix broken error message David Aguilar
2013-02-24 0:20 ` [PATCH 12/16] contrib/fast-import/import-zips.py: use spaces instead of tabs David Aguilar
2013-02-24 0:20 ` [PATCH 13/16] contrib/examples: make usage text consistent David Aguilar
2013-02-24 0:20 ` [PATCH 14/16] contrib/hooks/setgitperms.perl: " David Aguilar
2013-02-24 0:20 ` [PATCH 15/16] templates/hooks--update.sample: " David Aguilar
2013-02-24 0:20 ` [PATCH 16/16] Documentation/user-manual.txt: " David Aguilar
2013-02-24 0:25 ` Jonathan Nieder [this message]
2013-02-24 0:29 ` [PATCH 00/16] make usage text consistent in git commands Jonathan Nieder
2013-02-24 0:37 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130224002509.GG3222@elie.Belkin \
--to=jrnieder@gmail.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).