git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: David Madore <david+news@madore.org>
Cc: git@vger.kernel.org
Subject: Re: suggestion for a simple addition: git update-ref --ff-only
Date: Fri, 1 Mar 2013 20:10:50 -0500	[thread overview]
Message-ID: <20130302011049.GA16458@sigill.intra.peff.net> (raw)
In-Reply-To: <20130301231859.GA334@achernar.madore.org>

On Sat, Mar 02, 2013 at 12:18:59AM +0100, David Madore wrote:

> I'd like to suggest a very simple, but IMHO quite useful, additional
> option to git-update-ref: an option --ff-only which would cause the
> command to refuse unless the current ref is an ancestor of the new
> one.
> 
> The reason I think it would be useful: I occasionally wish to perform
> a trivial (i.e., fast-forward) merge of some branch into another
> (e.g., after a git-fetch) without checking it out.  Now git-update-ref
> is perfect for that, but there is always the possibility of getting
> something wrong (which one would not have with git merge --ff-only,
> but the latter requires checking out the branch), and this option
> would avoid tedious verifications.

The update-ref command is plumbing, which is supposed to do one small,
well-defined job. But you can compose many plumbing commands to do what
you want:

  # input
  ref=refs/heads/master
  new=$some_sha1

  # where are we now?
  old=`git rev-parse --verify $ref` || exit 1

  # is it a fast-forward?
  if ! git merge-base --is-ancestor $old $new; then
    echo >&2 "Not a fast-forward"
    exit 1
  fi

  # update it; we do not have to worry about race conditions because
  # update-ref will abort if somebody touched the ref in the meantime
  git update-ref $ref $new $old

Yes, it's three commands instead of one, but it's much more flexible
(you get to write your own message, you can use the same "merge-base" to
handle the "already up to date" case, etc).

-Peff

      parent reply	other threads:[~2013-03-02  1:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-01 23:18 suggestion for a simple addition: git update-ref --ff-only David Madore
2013-03-01 23:33 ` Junio C Hamano
2013-03-02  1:10 ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130302011049.GA16458@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=david+news@madore.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).