From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Cristian Tibirna <ctibirna@giref.ulaval.ca>, git@vger.kernel.org
Subject: Re: fetch --no-tags with and w/o --all
Date: Wed, 6 Mar 2013 20:08:29 -0500 [thread overview]
Message-ID: <20130307010829.GB850@sigill.intra.peff.net> (raw)
In-Reply-To: <7vhakonirb.fsf@alter.siamese.dyndns.org>
On Wed, Mar 06, 2013 at 04:41:44PM -0800, Junio C Hamano wrote:
> > Or we could just pass them through. Looks like this was already fixed by
> > 8556646 (fetch --all: pass --tags/--no-tags through to each remote,
> > 2012-09-05), which is in v1.7.12.2 and higher.
>
> ;-) No wonder this looked somewhat familiar.
I still find it somewhat gross that we actually re-construct the
command-line from the parsed flag variables. It seems like it would be
easier to simply propagate the argv we got in the first place, and then
we would not have any chance of omitting a new option that is added
later.
Probably not worth worrying about now, though, as the fix is long since
shipped. The next person who is adding an option can look at doing that
refactoring. And it may be that there are some options we don't
propagate intentionally (I didn't look closely).
-Peff
prev parent reply other threads:[~2013-03-07 1:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-06 21:33 fetch --no-tags with and w/o --all Cristian Tibirna
2013-03-06 21:56 ` Junio C Hamano
2013-03-07 0:20 ` Jeff King
2013-03-07 0:41 ` Junio C Hamano
2013-03-07 1:08 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130307010829.GB850@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=ctibirna@giref.ulaval.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).