From: Jeff King <peff@peff.net>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Mark Lodato <lodatom@gmail.com>,
Junio C Hamano <gitster@pobox.com>,
git list <git@vger.kernel.org>
Subject: Re: [PATCH] setup: suppress implicit "." work-tree for bare repos
Date: Fri, 8 Mar 2013 03:42:25 -0500 [thread overview]
Message-ID: <20130308084225.GA10963@sigill.intra.peff.net> (raw)
In-Reply-To: <513996D4.6060009@viscovery.net>
On Fri, Mar 08, 2013 at 08:44:20AM +0100, Johannes Sixt wrote:
> Am 3/8/2013 8:15, schrieb Jeff King:
> > --- a/cache.h
> > +++ b/cache.h
> > @@ -344,6 +344,7 @@ static inline enum object_type object_type(unsigned int mode)
> > #define GIT_DIR_ENVIRONMENT "GIT_DIR"
> > #define GIT_NAMESPACE_ENVIRONMENT "GIT_NAMESPACE"
> > #define GIT_WORK_TREE_ENVIRONMENT "GIT_WORK_TREE"
> > +#define GIT_IMPLICIT_WORK_TREE_ENVIRONMENT "GIT_IMPLICIT_WORK_TREE"
> > #define DEFAULT_GIT_DIR_ENVIRONMENT ".git"
> > #define DB_ENVIRONMENT "GIT_OBJECT_DIRECTORY"
> > #define INDEX_ENVIRONMENT "GIT_INDEX_FILE"
>
> This new variable needs to be added to environment.c:local_repo_env, right?
It does; I had no idea local_repo_env existed. We should add a comment
to cache.h to that effect, too.
-Peff
next prev parent reply other threads:[~2013-03-08 8:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 22:47 [BUG] bare repository detection does not work with aliases Mark Lodato
2013-03-08 5:48 ` Jeff King
2013-03-08 6:27 ` Junio C Hamano
2013-03-08 6:37 ` Jeff King
2013-03-08 7:15 ` [PATCH] setup: suppress implicit "." work-tree for bare repos Jeff King
2013-03-08 7:44 ` Johannes Sixt
2013-03-08 8:42 ` Jeff King [this message]
2013-03-08 9:28 ` [PATCHv2] setup and GIT_IMPLICIT_WORK_TREE Jeff King
2013-03-08 9:29 ` [PATCH v2 1/3] cache.h: drop LOCAL_REPO_ENV_SIZE Jeff King
2013-03-08 9:30 ` [PATCH v2 2/3] environment: add GIT_PREFIX to local_repo_env Jeff King
2013-03-08 21:39 ` Eric Sunshine
2013-03-08 21:44 ` Jeff King
2013-03-08 23:03 ` Junio C Hamano
2013-03-08 9:32 ` [PATCH v2 3/3] setup: suppress implicit "." work-tree for bare repos Jeff King
2013-03-08 7:54 ` [PATCH] " Junio C Hamano
2013-03-08 8:43 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308084225.GA10963@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=lodatom@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).