From: Jeff King <peff@peff.net>
To: Konstantin Khomoutov <kostix+git@007spb.ru>
Cc: git-users@googlegroups.com, Aleksey Rozhkov <ekkertan@gmail.com>,
git@vger.kernel.org
Subject: Re: git-scm.com/book/ru -- incorrect "next" link containing a question mark
Date: Fri, 8 Mar 2013 05:40:20 -0500 [thread overview]
Message-ID: <20130308104019.GA16068@sigill.intra.peff.net> (raw)
In-Reply-To: <20130307124736.3d738c5aab39345fa9ca2930@domain007.com>
On Thu, Mar 07, 2013 at 12:47:36PM +0400, Konstantin Khomoutov wrote:
> On Thu, 7 Mar 2013 00:01:31 -0800 (PST)
> Aleksey Rozhkov <ekkertan@gmail.com> wrote:
>
> > The page http://git-scm.com/book/ru/
> > Введение-Первоначальная-настройка-Git contains incorrect link "next"
> > Now this link to the page
> > http://git-scm.com/book/ru/Введение-Как-получить-помощь? , but this
> > page does not exist
>
> I would say "?" is just interpreted as a request part of the URL.
Yes, the problem is that the page's URL actually has the "?" in it,
but it needs to be URL-encoded in links.
> > So, correct link is
> > http://git-scm.com/book/ru/Введение-Как-получить-помощь%3F
>
> Good point, thanks. I Cc'ed the main Git list and made the message
> title a bit more clear.
Exactly. I fixed a few instances of this a while ago, but not the
prev/next pointers. This PR should fix all sites:
https://github.com/github/gitscm-next/pull/259
> To the Pro Git book maintainer: is it possible to somehow fix the HTML
> generation script to URL-encode any special characters if they're to
> appear in an URL?
I don't think Scott reads the list too closely these days. In general,
the best place to report git-scm.com problems is as an issue in the repo
linked above.
-Peff
prev parent reply other threads:[~2013-03-08 10:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <5fe58162-33ed-48c2-a095-e98a355ed4f6@googlegroups.com>
2013-03-07 8:47 ` git-scm.com/book/ru -- incorrect "next" link containing a question mark Konstantin Khomoutov
2013-03-08 10:40 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308104019.GA16068@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=ekkertan@gmail.com \
--cc=git-users@googlegroups.com \
--cc=git@vger.kernel.org \
--cc=kostix+git@007spb.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).