From: Fredrik Gustafsson <iveqy@iveqy.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Fredrik Gustafsson <iveqy@iveqy.com>,
gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] Replace strcmp_icase with strequal_icase
Date: Sat, 9 Mar 2013 13:22:00 +0100 [thread overview]
Message-ID: <20130309122200.GA7755@paksenarrion.iveqy.com> (raw)
In-Reply-To: <CACsJy8D4Yqm3s+ALf=KnMQRQ6SrVcM5jjktpGXiGcOaqtEsyMg@mail.gmail.com>
On Sat, Mar 09, 2013 at 07:05:37PM +0700, Duy Nguyen wrote:
> On Sat, Mar 9, 2013 at 6:08 PM, Fredrik Gustafsson <iveqy@iveqy.com> wrote:
> > Actually when implemented a str[n]equal_icase that actually should work.
> > I break the test suite when trying to replace
> > strncmp_icase(pathname, base, baselen)) on line 711 in dir.c and I don't
> > get any significant improvements.
>
> Hmm.. mine passed the test suite.
Using my patch or your own code? Maybe I just did something wrong. Could
you see any improvements in speed?
>
> > I like work in this area though, slow commit's are my worst git problem.
> > I often have to wait 10s. for a commit to be calculated.
>
> Personally I don't accept any often used git commands taking more than
> 1 second (in hot cache case). What commands do you use? What's the
> size of the repository in terms of tracked/untracked files?
It's a small repository, 100 MB. However I have a slow hdd which is
almost full. I often add one file and make an one-line change to an
other file and then do a git commit -a. That will make git to look
through the whole repo, which isn't in the kernel RAM cache but needs to
be reed from the hdd.
--
Med vänliga hälsningar
Fredrik Gustafsson
tel: 0733-608274
e-post: iveqy@iveqy.com
next prev parent reply other threads:[~2013-03-09 12:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-09 8:42 [PATCH] Replace strcmp_icase with strequal_icase Fredrik Gustafsson
2013-03-09 8:57 ` Fredrik Gustafsson
2013-03-09 10:21 ` Duy Nguyen
2013-03-09 10:40 ` Duy Nguyen
2013-03-09 10:54 ` Duy Nguyen
2013-03-09 11:08 ` Fredrik Gustafsson
2013-03-09 12:05 ` Duy Nguyen
2013-03-09 12:22 ` Fredrik Gustafsson [this message]
2013-03-09 12:40 ` Duy Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130309122200.GA7755@paksenarrion.iveqy.com \
--to=iveqy@iveqy.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).