From: Heiko Voigt <hvoigt@hvoigt.net>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Jens Lehmann <jens.lehmann@web.de>,
Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Subject: Re: [PATCH v2 4/4] teach config parsing to read from strbuf
Date: Thu, 14 Mar 2013 07:39:33 +0100 [thread overview]
Message-ID: <20130314063933.GB4062@sandbox-ub.fritz.box> (raw)
In-Reply-To: <20130312192959.GG17099@sigill.intra.peff.net>
On Tue, Mar 12, 2013 at 03:29:59PM -0400, Jeff King wrote:
> On Tue, Mar 12, 2013 at 05:42:54PM +0100, Heiko Voigt wrote:
>
> > > Your series does not actually add any callers of the new function. The
> > > obvious "patch 5/4" would be to plumb it into "git config --blob", and
> > > then we can just directly test it there (there could be other callers
> > > besides reading from a blob, of course, but I think the point of the
> > > series is to head in that direction).
> >
> > Since this is a split of the series mentioned above there are no real
> > callers yet. The main reason for the split was that I wanted to reduce
> > the review burden of one big series into multiple reviews of smaller
> > chunks. If you think it is useful to add the --blob option I can also
> > test from there. It could actually be useful to look at certain
> > .gitmodules options from the submodule script.
>
> I am on the fence. I do not want to create more work for you, but I do
> think it may come in handy, if only for doing submodule things from
> shell. And it is hopefully not a very large patch. I'd say try it, and
> if starts looking like it will be very ugly, the right thing may be to
> leave it until somebody really wants it.
Thats what I will do: Try it and see where I get.
Cheers Heiko
next prev parent reply other threads:[~2013-03-14 6:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 16:56 [PATCH v2 0/4] allow more sources for config values Heiko Voigt
2013-03-10 16:57 ` [PATCH v2 1/4] config: factor out config file stack management Heiko Voigt
2013-03-12 10:52 ` Jeff King
2013-03-12 15:44 ` Heiko Voigt
2013-03-12 19:04 ` Jeff King
2013-03-14 6:36 ` Heiko Voigt
2013-03-10 16:58 ` [PATCH v2 2/4] config: drop file pointer validity check in get_next_char() Heiko Voigt
2013-03-12 11:00 ` Jeff King
2013-03-12 16:00 ` Heiko Voigt
2013-03-12 16:16 ` Heiko Voigt
2013-03-12 19:26 ` Jeff King
2013-03-12 19:18 ` Jeff King
2013-03-10 16:59 ` [PATCH v2 3/4] config: make parsing stack struct independent from actual data source Heiko Voigt
2013-03-12 11:03 ` Jeff King
2013-03-12 16:27 ` Heiko Voigt
2013-03-12 19:27 ` Jeff King
2013-03-10 17:00 ` [PATCH v2 4/4] teach config parsing to read from strbuf Heiko Voigt
2013-03-12 11:18 ` Jeff King
2013-03-12 16:42 ` Heiko Voigt
2013-03-12 19:29 ` Jeff King
2013-03-14 6:39 ` Heiko Voigt [this message]
2013-03-14 7:10 ` Jeff King
2013-03-14 7:39 ` Jeff King
2013-03-18 14:18 ` Heiko Voigt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130314063933.GB4062@sandbox-ub.fritz.box \
--to=hvoigt@hvoigt.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jens.lehmann@web.de \
--cc=peff@peff.net \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).