From: Jeff King <peff@peff.net>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git
Date: Wed, 20 Mar 2013 13:26:40 -0400 [thread overview]
Message-ID: <20130320172640.GC10752@sigill.intra.peff.net> (raw)
In-Reply-To: <20130320170607.GB10752@sigill.intra.peff.net>
On Wed, Mar 20, 2013 at 01:06:07PM -0400, Jeff King wrote:
> On Wed, Mar 20, 2013 at 12:30:47PM +0100, Johannes Sixt wrote:
>
> > > I think that is OK, but I'm curious why this is a problem _now_, and not
> > > with the code prior to 97a83fa8. The old GIT_DEBUG_SEND_PACK was also
> > > just calling write() to descriptor 3.
> >
> > Before this change, both affected commands completed and the trace file
> > was empty. Notice that in both test cases we only check for the absence of
> > certain lines, which is naturally true for an empty file, so that the
> > tests pass.
>
> Hmm. The code in t5503 is similar, but before my patch used to actually
> use "test -s" to make sure that some trace output was written. Did it
> fail before 97a83fa8 (and does it pass now)?
Ah, I see. It did fail, and it was marked with NOT_MINGW. I think we can
fix that now. Patch coming in a moment.
-Peff
next prev parent reply other threads:[~2013-03-20 17:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 8:24 [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git Johannes Sixt
2013-03-20 9:33 ` Jeff King
2013-03-20 11:30 ` Johannes Sixt
2013-03-20 17:06 ` Jeff King
2013-03-20 17:26 ` Jeff King [this message]
2013-03-20 17:43 ` [PATCH] do not use GIT_TRACE_PACKET=3 in tests Jeff King
2013-03-20 20:29 ` Eric Sunshine
2013-03-20 20:58 ` Jeff King
2013-03-21 6:36 ` Johannes Sixt
2013-03-21 15:04 ` Junio C Hamano
2013-03-20 17:30 ` [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320172640.GC10752@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).