From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH 3/6] t5516 (fetch-push): introduce mk_test_with_name()
Date: Wed, 20 Mar 2013 11:28:30 -0700 [thread overview]
Message-ID: <20130320182830.GJ3655@google.com> (raw)
In-Reply-To: <1363783501-27981-4-git-send-email-artagnon@gmail.com>
Ramkumar Ramachandra wrote:
> mk_test() creates a repository with the constant name "testrepo", and
> this may be limiting for tests that need to create more than one
> repository for testing. To fix this, create a new mk_test_with_name()
> which accepts the repository name as $1. Reimplement mk_test() as a
> special case of this function, making sure that no tests need to be
> rewritten.
Why not give mk_test an optional parameter?
repo_name=${1:-testrepo}
Oh, it is because mk_test already takes arguments naming refs to push.
I suppose the change description could make this clearer.
Why not use mk_test and then rename, like so?
mk_test ...refs... &&
mv testrepo testrepo-a &&
mk_test ...refs... &&
mv testrepo testrepo-b &&
...
I dunno. The helper functions at the top of this test are already
intimidating, so I guess I am looking for a way to avoid making that
problem worse. One way would be to add an opening comment before
the function definition explaining how it is meant to be used. See
t/test-lib-functions.sh for examples, such as test_cmp.
Hope that helps,
Jonathan
next prev parent reply other threads:[~2013-03-20 18:29 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 12:44 [PATCH v2 0/6] Support triangular workflows Ramkumar Ramachandra
2013-03-20 12:44 ` [PATCH 1/6] remote.c: simplify a bit of code using git_config_string() Ramkumar Ramachandra
2013-03-20 18:07 ` Jonathan Nieder
2013-03-20 18:12 ` Ramkumar Ramachandra
2013-03-20 12:44 ` [PATCH 2/6] t5516 (fetch-push): update test description Ramkumar Ramachandra
2013-03-20 18:22 ` Jonathan Nieder
2013-03-20 18:33 ` Ramkumar Ramachandra
2013-03-20 18:35 ` Jonathan Nieder
2013-03-20 12:44 ` [PATCH 3/6] t5516 (fetch-push): introduce mk_test_with_name() Ramkumar Ramachandra
2013-03-20 18:28 ` Jonathan Nieder [this message]
2013-03-20 18:38 ` Ramkumar Ramachandra
2013-03-20 18:41 ` Jonathan Nieder
2013-03-20 18:58 ` Jeff King
2013-03-20 19:52 ` Junio C Hamano
2013-03-20 20:00 ` Jonathan Nieder
2013-03-20 12:44 ` [PATCH 4/6] remote.c: introduce a way to have different remotes for fetch/push Ramkumar Ramachandra
2013-03-20 18:30 ` Jonathan Nieder
2013-03-20 19:03 ` Junio C Hamano
2013-03-20 19:43 ` Ramkumar Ramachandra
2013-03-20 19:48 ` Junio C Hamano
2013-03-20 12:45 ` [PATCH 5/6] remote.c: introduce remote.pushdefault Ramkumar Ramachandra
2013-03-20 18:32 ` Jonathan Nieder
2013-03-20 18:53 ` Junio C Hamano
2013-03-20 19:46 ` Ramkumar Ramachandra
2013-03-20 12:45 ` [PATCH 6/6] remote.c: introduce branch.<name>.pushremote Ramkumar Ramachandra
2013-03-20 13:03 ` Tay Ray Chuan
2013-03-20 13:35 ` Ramkumar Ramachandra
2013-03-20 13:06 ` [PATCH v2 0/6] Support triangular workflows Tay Ray Chuan
2013-03-22 7:44 ` Ramkumar Ramachandra
2013-03-20 23:04 ` Philip Oakley
2013-03-22 7:41 ` Ramkumar Ramachandra
2013-03-22 15:16 ` Junio C Hamano
2013-03-23 12:42 ` Ramkumar Ramachandra
-- strict thread matches above, loose matches on Subject: below --
2013-03-22 7:52 [PATCH v3 " Ramkumar Ramachandra
2013-03-22 7:52 ` [PATCH 3/6] t5516 (fetch-push): introduce mk_test_with_name() Ramkumar Ramachandra
2013-03-22 14:44 ` Jeff King
2013-03-22 14:52 ` Junio C Hamano
2013-03-22 14:59 ` Jeff King
2013-03-22 21:14 ` Jonathan Nieder
2013-03-28 13:03 ` Ramkumar Ramachandra
2013-03-22 14:54 ` Junio C Hamano
2013-03-22 14:58 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320182830.GJ3655@google.com \
--to=jrnieder@gmail.com \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).