From: Jeff King <peff@peff.net>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>,
Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] do not use GIT_TRACE_PACKET=3 in tests
Date: Wed, 20 Mar 2013 16:58:36 -0400 [thread overview]
Message-ID: <20130320205836.GA1373@sigill.intra.peff.net> (raw)
In-Reply-To: <CAPig+cQhG-oE5n-RjxhHqGoPzTZbLGagU+9gxzrJhaOcUAtffQ@mail.gmail.com>
On Wed, Mar 20, 2013 at 04:29:40PM -0400, Eric Sunshine wrote:
> On Wed, Mar 20, 2013 at 1:43 PM, Jeff King <peff@peff.net> wrote:
> > Some test scripts use the GIT_TRACE mechanism to dump
> > debugging information to descriptor 3 (and point it to a
> > file using the shell). On Windows, however, bash is unable
> > to set up descriptor 3. We do not write our trace to the
> > file, and worse, we may interfere with other operations
> > happening on descriptor 3, causing tests to fail or other
> > even behave inconsistently.
>
> s/other even/even/
Urgh, I should probably add another proofreading pass to my commit
messages. Thanks.
-Peff
next prev parent reply other threads:[~2013-03-20 20:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-20 8:24 [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git Johannes Sixt
2013-03-20 9:33 ` Jeff King
2013-03-20 11:30 ` Johannes Sixt
2013-03-20 17:06 ` Jeff King
2013-03-20 17:26 ` Jeff King
2013-03-20 17:43 ` [PATCH] do not use GIT_TRACE_PACKET=3 in tests Jeff King
2013-03-20 20:29 ` Eric Sunshine
2013-03-20 20:58 ` Jeff King [this message]
2013-03-21 6:36 ` Johannes Sixt
2013-03-21 15:04 ` Junio C Hamano
2013-03-20 17:30 ` [PATCH jk/pkt-line-cleanup] t5700-clone-reference: send trace to fd 2, not 3, to please Windows git Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130320205836.GA1373@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).