From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Josh Sharpe <josh.m.sharpe@gmail.com>, git@vger.kernel.org
Subject: Re: feature request - have git honor nested .gitconfig files
Date: Fri, 22 Mar 2013 14:33:06 -0400 [thread overview]
Message-ID: <20130322183306.GA32448@sigill.intra.peff.net> (raw)
In-Reply-To: <20130322182211.GD12223@google.com>
On Fri, Mar 22, 2013 at 11:22:11AM -0700, Jonathan Nieder wrote:
> * Maintaining configuration per repository to record a rather simple
> is more complicated than ideal. It would be easier to understand
> the configuration if ~/.gitconfig could spell out the rule
> explicitly:
>
> [include]
> path = cond(starts_with($GIT_DIR, ~/dev/),
> ~/.config/git/dev-config,
> ~/.config/git/nondev-config)
>
> This means supporting an extension language in the config file.
> It sounds hard to do right, especially considering use cases like
> "User runs into trouble, asks a privileged sysadmin to try running
> a command in her untrusted repository", but it is worth thinking
> about how to do.
I'd rather not invent a new language. It will either not be featureful
enough, or will end up bloated. Or both. How about something like:
[include]
exec = "
case \"$GIT_DIR\" in)
*/dev/*) cat ~/.config/git/dev-config ;;
*) cat ~/.config/git/nondev-config ;;
esac
"
It involves a shell invocation, but it's not like we parse config in a
tight loop. Bonus points if git provides the name of the current config
file, so exec can use relative paths like:
cat "$(dirname $GIT_CONFIG_FILE)"/dev-config
> * The "Includes" facility is annoyingly close to being helpful.
> An include.path setting from ~/.gitconfig cannot refer to $GIT_DIR
> by name.
Yeah, we do not allow variable expansion at all beyond the usual path
mechanisms. I think if you had $GIT_DIR, though, it would end up
annoying. You do not want one file in ~/.config/git per $GIT_DIR, so
you would need some way of munging $GIT_DIR into your naming scheme.
-Peff
next prev parent reply other threads:[~2013-03-22 18:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-22 16:50 feature request - have git honor nested .gitconfig files Josh Sharpe
2013-03-22 18:22 ` Jonathan Nieder
2013-03-22 18:33 ` Jeff King [this message]
2013-03-23 0:06 ` Jonathan Nieder
2013-03-23 8:03 ` Jeff King
2013-03-24 7:14 ` Junio C Hamano
2013-03-23 6:15 ` Thomas Rast
2013-03-23 8:06 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130322183306.GA32448@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=josh.m.sharpe@gmail.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).