From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: "Yi, EungJun" <semtlenori@gmail.com>, git@vger.kernel.org
Subject: Re: More detailed error message for 403 forbidden.
Date: Thu, 28 Mar 2013 14:45:30 -0400 [thread overview]
Message-ID: <20130328184530.GA14691@sigill.intra.peff.net> (raw)
In-Reply-To: <20130328184120.GQ28148@google.com>
On Thu, Mar 28, 2013 at 11:41:20AM -0700, Jonathan Nieder wrote:
> Jeff King wrote:
>
> > One problem is that the content body sent along with the error is not
> > necessarily appropriate for showing to the user (e.g., if it is HTML, it
> > is probably not a good idea to show it on the terminal). So I think we
> > would want to only show it when the server has indicated via the
> > content-type that the message is meant to be shown to the user. I'm
> > thinking the server would generate something like:
> >
> > HTTP/1.1 403 Forbidden
> > Content-type: application/x-git-error-message
> >
> > User 'me' does not have enough permission to access the repository.
> >
> > which would produce the example you showed above.
>
> Would it make sense to use text/plain this way?
Maybe. But I would worry somewhat about sites which provide a useless
and verbose text/plain message. Ideally an x-git-error-message would be
no more than few lines, suitable for the error message of a terminal
program. I would not want a site-branded "Your page cannot be found.
Here's a complete navigation bar" page to be spewed to the terminal.
Those tend to be text/html, though, so we may be safe. It's just that
we're gambling on what random servers do, and if we show useless spew
even some of the time, that would be a regression.
-Peff
next prev parent reply other threads:[~2013-03-28 18:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-27 3:29 More detailed error message for 403 forbidden Yi, EungJun
2013-03-28 18:36 ` Jeff King
2013-03-28 18:41 ` Jonathan Nieder
2013-03-28 18:45 ` Jeff King [this message]
2013-03-31 9:17 ` Yi, EungJun
2013-03-28 19:11 ` Junio C Hamano
2013-03-28 20:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130328184530.GA14691@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=semtlenori@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).