git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@samba.org>
To: Dirk <dirk@freunde-aus-berlin.net>
Cc: git@vger.kernel.org
Subject: Re: [Patch] gitk: added a file history browser
Date: Mon, 1 Apr 2013 18:24:08 +1100	[thread overview]
Message-ID: <20130401072408.GB4427@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <0063A4B3-8C79-4F2F-97C7-D14AEBB17DEC@freunde-aus-berlin.net>

On Wed, Feb 20, 2013 at 12:14:20AM +0100, Dirk wrote:
> Hi,
> 
> I added a file history browser for a single file in the gitk. I use git log with the option --follow. This option is useful for the user switch from cvs to git. He misses a history from only one file and the function "Highlight this only" breaks by moved files. The new option do not break by the moved files. I use ideas from the tkcvs branch dialog.

How is this better than running "gitk --follow -- file"?

Also, it's rather a large patch with only a two-line patch description,
which is not really adequate.  And it's missing a Signed-off-by.

I think the right way to do this is to have the file menu option
create a new view specifying the file and the --follow option,
rather than creating a whole new window.

Paul.

      reply	other threads:[~2013-04-01  7:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-19 23:14 [Patch] gitk: added a file history browser Dirk
2013-04-01  7:24 ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130401072408.GB4427@iris.ozlabs.ibm.com \
    --to=paulus@samba.org \
    --cc=dirk@freunde-aus-berlin.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).