From: Jeff King <peff@peff.net>
To: Antoine Pelisse <apelisse@gmail.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
git <git@vger.kernel.org>, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/3] remote-helpers: fix the run of all tests
Date: Mon, 1 Apr 2013 19:40:16 -0400 [thread overview]
Message-ID: <20130401234016.GC30935@sigill.intra.peff.net> (raw)
In-Reply-To: <CALWbr2wAqudzbfiSHmD1uAVQX3mtbf5vgr2JXbXEg7yzaKXJcw@mail.gmail.com>
On Mon, Apr 01, 2013 at 11:46:00PM +0200, Antoine Pelisse wrote:
> On Mon, Apr 1, 2013 at 11:14 PM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> > +export TEST_LINT :=
>
> I think "test-lint-executable" still makes sense here.
Also test-lint-shell-syntax, which finds a problem with the current
code:
$ cd contrib/remote-helpers
$ make test TEST_LINT=test-lint-shell-syntax
make -e -C ../../t test
make[1]: Entering directory `/home/peff/compile/git/t'
rm -f -r test-results
/home/peff/compile/git/contrib/remote-helpers/test-bzr.sh:139: error: echo -n is not portable (please use printf): echo -n content > expected &&
make[1]: *** [test-lint-shell-syntax] Error 1
make[1]: Leaving directory `/home/peff/compile/git/t'
make: *** [test] Error 2
I think the check for duplicate-numbers is the only one that does not
make sense. Unfortunately it is not as simple as using $(filter-out) to
get rid of it from TEST_LINT, as that variable may not even be set until
we chain to the other Makefile (e.g., if it comes from loading
config.mak).
-Peff
next prev parent reply other threads:[~2013-04-01 23:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 21:14 [PATCH 0/3] remote-helpers: trivial test fixes Felipe Contreras
2013-04-01 21:14 ` [PATCH 1/3] remote-helpers: fix the run of all tests Felipe Contreras
2013-04-01 21:46 ` Antoine Pelisse
2013-04-01 23:40 ` Jeff King [this message]
2013-04-02 16:53 ` Torsten Bögershausen
2013-04-02 17:36 ` Jeff King
2013-04-03 5:53 ` Torsten Bögershausen
2013-04-03 14:57 ` Junio C Hamano
2013-04-04 15:36 ` Felipe Contreras
2013-04-01 21:14 ` [PATCH 2/3] remote-bzr: remove stale check code for tests Felipe Contreras
2013-04-01 22:46 ` Junio C Hamano
2013-04-01 21:14 ` [PATCH 3/3] remote-hg: fix hg-git test-case Felipe Contreras
2013-04-01 21:48 ` [PATCH 0/3] remote-helpers: trivial test fixes Antoine Pelisse
2013-04-01 21:56 ` Felipe Contreras
2013-04-01 22:46 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130401234016.GC30935@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=apelisse@gmail.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).