From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Johannes Sixt <j6t@kdbg.org>, Aaron Schrab <aaron@schrab.com>,
Clemens Buchacher <drizzd@aon.at>,
David Michael Barr <b@rr-dav.id.au>,
Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Subject: Re: [PATCH 1/4] run-command: add new check_command helper
Date: Tue, 2 Apr 2013 01:14:07 -0400 [thread overview]
Message-ID: <20130402051407.GA21906@sigill.intra.peff.net> (raw)
In-Reply-To: <CAMP44s3-DnBM7Tm_+igLN+c5MGrbJNXUBwcj1HvGCPEJEwJSBQ@mail.gmail.com>
On Mon, Apr 01, 2013 at 11:11:20PM -0600, Felipe Contreras wrote:
> > But if we know from reading waitpid(3) that waitpid should only fail due
> > to EINTR, or due to bogus arguments (e.g., a pid that does not exist or
> > has already been reaped), then maybe something like this makes sense:
> >
> > while ((waiting = waitpid(pid, &status, 0)) < 0 && errno == EINTR)
> > ; /* nothing */
>
> But we don't want to wait synchronously here, we just want to ping.
Yeah, sorry, I forgot the WNOHANG there.
> > After the fix above, yes; in the original we would always have exited
> > already.
>
> No:
>
> + if (waiting != cmd->pid)
> + return 1;
>
> If waiting < 0, waiting != cmd->pid, and therefore this return is not
> triggered, and there's only one more return at the end of the
> function.
Are my eyes not working? If waiting < 0, then waiting != cmd->pid, and
therefore this return _is_ triggered.
-Peff
next prev parent reply other threads:[~2013-04-02 5:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-01 21:46 [PATCH 0/4] run-command: new check_command helper Felipe Contreras
2013-04-01 21:46 ` [PATCH 1/4] run-command: add " Felipe Contreras
2013-04-01 23:23 ` Jeff King
2013-04-01 23:58 ` Felipe Contreras
2013-04-02 2:22 ` Jeff King
2013-04-02 5:11 ` Felipe Contreras
2013-04-02 5:14 ` Jeff King [this message]
2013-04-02 5:22 ` Felipe Contreras
2013-04-02 5:26 ` Jeff King
2013-04-01 21:46 ` [PATCH 2/4] transport-helper: check if remote helper is alive Felipe Contreras
2013-04-01 23:33 ` Jeff King
2013-04-02 0:12 ` Felipe Contreras
2013-04-02 2:30 ` Jeff King
2013-04-02 4:51 ` Felipe Contreras
2013-04-02 5:01 ` Jeff King
2013-04-02 5:19 ` Felipe Contreras
2013-04-02 9:36 ` Felipe Contreras
2013-04-02 0:26 ` Junio C Hamano
2013-04-02 4:58 ` Felipe Contreras
2013-04-01 21:46 ` [PATCH 3/4] tmp: remote-helper: add timers to catch errors Felipe Contreras
2013-04-01 21:46 ` [PATCH 4/4] tmp: run-command: code to exercise check_command Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130402051407.GA21906@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=aaron@schrab.com \
--cc=b@rr-dav.id.au \
--cc=drizzd@aon.at \
--cc=felipe.contreras@gmail.com \
--cc=florian.achleitner.2.6.31@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).