From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: jpinheiro <7jpinheiro@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 3/3] t3600: test rm of path with changed leading symlinks
Date: Thu, 4 Apr 2013 19:29:04 -0400 [thread overview]
Message-ID: <20130404232903.GA27128@sigill.intra.peff.net> (raw)
In-Reply-To: <7vhajlgabi.fsf@alter.siamese.dyndns.org>
On Thu, Apr 04, 2013 at 04:12:01PM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Deleting across symlinks inside the repo can be brushed aside with "eh,
> > well, it is just another way to mention the same name in the
> > filesystem". But deleting anything outside of the repo seems actively
> > wrong.
>
> Yup, you finally caught up ;-) IIRC, such an outside repository
> target was the case people realized that "git add" shouldn't see
> across symlinks.
It would help if you spelled it out rather than making me come to it
while arguing against you. ;P
> > Hmm. I think you have convinced me (or perhaps I have convinced myself)
> > that we should generally not be crossing symlink boundaries in
> > translating names between the filesystem and index. I still don't want
> > to work on it, though. :)
>
> That is OK. Just let's not etch a wrong behaviour in stone with
> that test.
So let's drop patch 3. Do we want instead to have an expect_failure
documenting the correct behavior?
-Peff
next prev parent reply other threads:[~2013-04-04 23:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 14:50 Behavior of git rm jpinheiro
2013-04-03 15:58 ` Jeff King
2013-04-03 17:35 ` Junio C Hamano
2013-04-03 20:36 ` Jeff King
2013-04-04 19:02 ` Jeff King
2013-04-04 19:03 ` [PATCH 1/3] rm: do not complain about d/f conflicts during deletion Jeff King
2013-04-04 19:03 ` [PATCH 2/3] t3600: test behavior of reverse-d/f conflict Jeff King
2013-04-04 19:06 ` [PATCH 3/3] t3600: test rm of path with changed leading symlinks Jeff King
2013-04-04 19:42 ` Junio C Hamano
2013-04-04 19:55 ` Jeff King
2013-04-04 20:31 ` Junio C Hamano
2013-04-04 21:03 ` Jeff King
2013-04-04 23:12 ` Junio C Hamano
2013-04-04 23:29 ` Jeff King [this message]
2013-04-04 23:33 ` Junio C Hamano
2013-04-05 0:00 ` Jeff King
2013-04-05 4:59 ` Junio C Hamano
2013-04-05 5:04 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130404232903.GA27128@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=7jpinheiro@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).