From: "Torsten Bögershausen" <tboegi@web.de>
To: git@vger.kernel.org
Cc: felipe.contreras@gmail.com, tboegi@web.de
Subject: [PATCH] remote-helpers/test-bzr.sh: do not use grep \s
Date: Sun, 7 Apr 2013 10:48:30 +0200 [thread overview]
Message-ID: <201304071048.31790.tboegi@web.de> (raw)
Using grep "devel\s\+3:" to find at least one whitspace
is not portable on all grep versions:
Not all grep versions understand "\s" as a "whitespace".
Use a literal TAB followed by SPACE like this [ ] instead.
The + as a qualifier for "one or more" is not a basic regular expression:
use egrep instead of grep.
Signed-off-by: Torsten Bögershausen <tboegi@web.de>
---
contrib/remote-helpers/test-hg.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/contrib/remote-helpers/test-hg.sh b/contrib/remote-helpers/test-hg.sh
index 5f81dfa..7bb81f2 100755
--- a/contrib/remote-helpers/test-hg.sh
+++ b/contrib/remote-helpers/test-hg.sh
@@ -115,7 +115,7 @@ test_expect_success 'update bookmark' '
git push
) &&
- hg -R hgrepo bookmarks | grep "devel\s\+3:"
+ hg -R hgrepo bookmarks | egrep "devel[ ]+3:"
'
test_done
--
1.8.2.341.g543621f
next reply other threads:[~2013-04-07 8:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 8:48 Torsten Bögershausen [this message]
2013-04-07 9:02 ` [PATCH] remote-helpers/test-bzr.sh: do not use grep \s Felipe Contreras
2013-04-07 9:04 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201304071048.31790.tboegi@web.de \
--to=tboegi@web.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).