git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Simon Ruderich <simon@ruderich.org>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>,
	Thomas Rast <trast@student.ethz.ch>,
	Stephen Boyd <bebarino@gmail.com>,
	Daniel Barkalow <barkalow@iabervon.org>
Subject: Re: [PATCH v4 5/6] format-patch: add format.cover-letter configuration
Date: Sun, 7 Apr 2013 15:32:00 -0700	[thread overview]
Message-ID: <20130407223200.GF19857@elie.Belkin> (raw)
In-Reply-To: <20130407193415.GB13708@ruderich.org>

Hi,

Simon Ruderich wrote:
> On Sun, Apr 07, 2013 at 12:46:23PM -0500, Felipe Contreras wrote:

>> +test_expect_success 'cover letter auto' '
>> +	mkdir -p tmp &&
>> +	test_when_finished "rm -rf tmp;
[...]
> I'm not sure if it's better to use test_when_finished with rm or
> just && rm -rf tmp at the end of the test in case someone wants
> to look at the output.

test_when_finished is better here, since it means later tests can
run and provide useful information about how bad a regression is.
Cleanup commands requested using test_when_finished are not run when a
test being run with --immediate fails, so you can still inspect output
after a failed test.

Thanks and hope that helps,
Jonathan

  reply	other threads:[~2013-04-08  6:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-07 17:46 [PATCH v4 0/6] send-email: configuration improvements Felipe Contreras
2013-04-07 17:46 ` [PATCH v4 1/6] send-email: make annotate configurable Felipe Contreras
2013-04-09 13:51   ` Jakub Narębski
2013-04-07 17:46 ` [PATCH v4 2/6] format-patch: improve head calculation for cover-letter Felipe Contreras
2013-04-07 17:46 ` [PATCH v4 3/6] format-patch: refactor branch name calculation Felipe Contreras
2013-04-07 17:46 ` [PATCH v4 4/6] log: update to OPT_BOOL Felipe Contreras
2013-04-07 17:46 ` [PATCH v4 5/6] format-patch: add format.cover-letter configuration Felipe Contreras
2013-04-07 19:34   ` Simon Ruderich
2013-04-07 22:32     ` Jonathan Nieder [this message]
2013-04-09 13:18       ` [PATCH] t/README: --immediate skips cleanup commands for failed tests Simon Ruderich
2013-04-09 19:16         ` Junio C Hamano
2013-04-09 21:48           ` [PATCH v2] " Simon Ruderich
2013-04-07 17:46 ` [PATCH v4 6/6] format-patch: trivial cleanups Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130407223200.GF19857@elie.Belkin \
    --to=jrnieder@gmail.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=barkalow@iabervon.org \
    --cc=bebarino@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=simon@ruderich.org \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).