git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aaron Schrab <aaron@schrab.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 1/2] clone: Fix error message for reference repository
Date: Mon, 8 Apr 2013 14:58:24 -0400	[thread overview]
Message-ID: <20130408185823.GL27178@pug.qqx.org> (raw)
In-Reply-To: <7vli8sykf0.fsf@alter.siamese.dyndns.org>

At 10:57 -0700 08 Apr 2013, Junio C Hamano <gitster@pobox.com> wrote:
>In general I am in favor of resolving a gitfile given to --reference
>when clone interprets it, and have it use the location of the real
>underlying object store when it grabs objects not in there from the
>origin and store the location of the real underlying object store in
>the objects/info/alternates of the newly created repository.  But
>that is not limited to the gitfile used at the root level of a
>submodule checkout.

Yes, I agree that it's not limited to submodules.  The commit message 
for the second part of this series only mentioned submodules because I 
suspect that is by far the most common use of gitfiles.  The commit 
message for the first didn't even mention submodules at all, they were 
only brought up because I was asked about what lead to me having an 
issue.

>Blindly using .git at the root level of submodule checkout as a
>reference is what I was recommending against as a general
>precaution.

I agree with that.  But I still don't think it's relevant to this patch 
series.

>You may be dealing with an old-style submodule checkout.

No, the submodule in question was done with the new style.  If it were 
an old-style checkout my attempt to clone using that as a reference 
would have worked without issue (at least at clone time).

  reply	other threads:[~2013-04-08 18:58 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-07 23:17 [PATCH 1/2] clone: Fix error message for reference repository Aaron Schrab
2013-04-07 23:17 ` [PATCH 2/2] clone: Allow repo using gitfile as a reference Aaron Schrab
2013-04-07 23:51   ` Jonathan Nieder
2013-04-08  0:08     ` Aaron Schrab
2013-04-08 18:00       ` Junio C Hamano
2013-04-08 18:59         ` Aaron Schrab
2013-04-08 22:46           ` [PATCH v2 0/2] Using gitfile repository with clone --reference Aaron Schrab
2013-04-08 22:46             ` [PATCH 1/2] clone: Fix error message for reference repository Aaron Schrab
2013-04-09  0:18               ` Jonathan Nieder
2013-04-08 22:46             ` [PATCH 2/2] clone: Allow repo using gitfile as a reference Aaron Schrab
2013-04-09  0:24               ` Jonathan Nieder
2013-04-09 16:31                 ` Aaron Schrab
2013-04-09 16:47                   ` Junio C Hamano
2013-04-09 16:50                     ` Aaron Schrab
2013-04-09 22:21                     ` [PATCH v3 0/2] Using gitfile repository with clone --reference Aaron Schrab
2013-04-09 22:21                       ` [PATCH v3 1/2] clone: Fix error message for reference repository Aaron Schrab
2013-04-09 22:22                       ` [PATCH v3 2/2] clone: Allow repo using gitfile as a reference Aaron Schrab
2013-04-09 22:41                       ` [PATCH v3 0/2] Using gitfile repository with clone --reference Junio C Hamano
2013-04-07 23:48 ` [PATCH 1/2] clone: Fix error message for reference repository Jonathan Nieder
2013-04-08  0:06   ` Aaron Schrab
2013-04-08  1:11     ` Aaron Schrab
2013-04-08 13:58     ` Junio C Hamano
2013-04-08 14:57       ` Aaron Schrab
2013-04-08 15:30         ` Junio C Hamano
2013-04-08 16:17           ` Aaron Schrab
2013-04-08 17:57             ` Junio C Hamano
2013-04-08 18:58               ` Aaron Schrab [this message]
2013-04-08 19:10                 ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130408185823.GL27178@pug.qqx.org \
    --to=aaron@schrab.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).