From: Jeff King <peff@peff.net>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
Git List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH v4] transport-helper: report errors properly
Date: Mon, 8 Apr 2013 15:30:43 -0400 [thread overview]
Message-ID: <20130408193043.GD7337@sigill.intra.peff.net> (raw)
In-Reply-To: <CAGdFq_h9o+oMriF52Bh2e60eJfLM7F9GTbwcSE1mD3Leyt76Yg@mail.gmail.com>
On Mon, Apr 08, 2013 at 11:20:15AM -0700, Sverre Rabbelier wrote:
> On Mon, Apr 8, 2013 at 7:40 AM, Felipe Contreras
> <felipe.contreras@gmail.com> wrote:
> > + die("Reading from remote helper failed");
>
> Does the user know what a remote helper is? Could we point them at
> some helpful docs in case they don't?
That's a good point. I wonder if it would be enough to say:
fatal: Reading from helper git-remote-X failed
That might make it more clear what the helper's role is, and showing the
command name gives the user a starting point for running "man".
-Peff
next prev parent reply other threads:[~2013-04-08 19:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-08 14:40 [PATCH v4] transport-helper: report errors properly Felipe Contreras
2013-04-08 18:20 ` Sverre Rabbelier
2013-04-08 19:30 ` Jeff King [this message]
2013-04-08 19:28 ` Jeff King
2013-04-09 21:38 ` Thomas Rast
2013-04-09 21:50 ` Jeff King
2013-04-10 21:13 ` [PATCH v5 0/2] reporting transport helper errors Jeff King
2013-04-10 21:15 ` [PATCH 1/2] transport-helper: report errors properly Jeff King
2013-04-10 21:22 ` Sverre Rabbelier
2013-04-10 21:46 ` Eric Sunshine
2013-04-11 13:22 ` Felipe Contreras
2013-04-11 16:18 ` Jeff King
2013-04-11 16:49 ` Felipe Contreras
2013-04-11 16:59 ` Jeff King
2013-04-11 17:57 ` Felipe Contreras
2013-04-11 18:49 ` Junio C Hamano
2013-04-11 21:35 ` Felipe Contreras
2013-04-11 18:44 ` Junio C Hamano
2013-04-11 21:21 ` Felipe Contreras
2013-04-11 23:05 ` Junio C Hamano
2013-04-13 5:42 ` Felipe Contreras
2013-04-13 6:00 ` Jeff King
2013-04-13 6:43 ` Felipe Contreras
2013-04-14 5:23 ` Junio C Hamano
2013-04-14 15:54 ` Felipe Contreras
2013-04-10 21:16 ` [PATCH 2/2] transport-helper: mention helper name when it dies Jeff King
2013-04-10 21:23 ` Sverre Rabbelier
2013-04-10 21:28 ` Jeff King
2013-04-10 21:35 ` Sverre Rabbelier
2013-04-10 23:13 ` [PATCH v4] transport-helper: report errors properly rh
2013-04-11 3:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408193043.GD7337@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).