From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org, Johannes Sixt <j6t@kdbg.org>,
Aaron Schrab <aaron@schrab.com>,
Clemens Buchacher <drizzd@aon.at>,
David Michael Barr <b@rr-dav.id.au>,
Florian Achleitner <florian.achleitner.2.6.31@gmail.com>
Subject: Re: [PATCH v3 2/2] transport-helper: check if remote helper is alive
Date: Mon, 8 Apr 2013 17:11:54 -0400 [thread overview]
Message-ID: <20130408211154.GA10310@sigill.intra.peff.net> (raw)
In-Reply-To: <7vy5csvih8.fsf@alter.siamese.dyndns.org>
On Mon, Apr 08, 2013 at 02:08:03PM -0700, Junio C Hamano wrote:
> OK, so you are envisioning that transport-helper would read from the
> helper after importer is done? If so, perhaps it is a prudent
> solution to disconnect in this version (to fix), and then in a
> separate patch that adds such an extension (I imagine it would
> involve that the helper advertising a capability or being invoked
> with an option to let transport-helper somehow know that it should
> continue the conversation once fast-import is done) to disable the
> disconnect here when that extension is in use?
At this point, I am of the opinion that it's OK to just do nothing;
modern helpers should be using the "done" flag, and if they aren't, then
that is the right place for the fix. Then we don't have to worry about
any side effects of disconnecting, or adding a new capability flag.
-Peff
next prev parent reply other threads:[~2013-04-08 21:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 7:45 [PATCH v3 0/2] run-command: new check_command helper Felipe Contreras
2013-04-07 7:45 ` [PATCH v3 1/2] run-command: add " Felipe Contreras
2013-04-07 17:47 ` Junio C Hamano
2013-04-07 17:52 ` Junio C Hamano
2013-04-07 7:45 ` [PATCH v3 2/2] transport-helper: check if remote helper is alive Felipe Contreras
2013-04-07 17:49 ` Junio C Hamano
2013-04-08 0:51 ` Jeff King
2013-04-08 2:03 ` Felipe Contreras
2013-04-08 2:33 ` Jeff King
2013-04-08 14:38 ` Felipe Contreras
2013-04-08 17:43 ` Junio C Hamano
2013-04-08 18:31 ` Felipe Contreras
2013-04-08 18:46 ` Junio C Hamano
2013-04-08 19:08 ` Felipe Contreras
2013-04-08 21:08 ` Junio C Hamano
2013-04-08 21:11 ` Jeff King [this message]
2013-04-08 21:21 ` Junio C Hamano
2013-04-08 18:49 ` Jeff King
2013-04-08 19:15 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130408211154.GA10310@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=aaron@schrab.com \
--cc=b@rr-dav.id.au \
--cc=drizzd@aon.at \
--cc=felipe.contreras@gmail.com \
--cc=florian.achleitner.2.6.31@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).