From: Jonathan Nieder <jrnieder@gmail.com>
To: Aaron Schrab <aaron@schrab.com>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 1/2] clone: Fix error message for reference repository
Date: Mon, 8 Apr 2013 17:18:17 -0700 [thread overview]
Message-ID: <20130409001817.GV30308@google.com> (raw)
In-Reply-To: <1365461200-13509-2-git-send-email-aaron@schrab.com>
Aaron Schrab wrote:
> Do not report that an argument to clone's --reference option is not a
> local directory. Nothing checks for the existence or type of the path
> as supplied by the user; checks are only done for particular contents of
> the supposed directory, so we have no way to know the status of the
> supplied path.
Yes, makes sense.
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
My only remaining qualm is that a person could be confused by the
message after trying to pass in --reference=file:///path/to/repo, but
I guess that trial and error would eventually lead such a person in
the right direction.
next prev parent reply other threads:[~2013-04-09 0:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 23:17 [PATCH 1/2] clone: Fix error message for reference repository Aaron Schrab
2013-04-07 23:17 ` [PATCH 2/2] clone: Allow repo using gitfile as a reference Aaron Schrab
2013-04-07 23:51 ` Jonathan Nieder
2013-04-08 0:08 ` Aaron Schrab
2013-04-08 18:00 ` Junio C Hamano
2013-04-08 18:59 ` Aaron Schrab
2013-04-08 22:46 ` [PATCH v2 0/2] Using gitfile repository with clone --reference Aaron Schrab
2013-04-08 22:46 ` [PATCH 1/2] clone: Fix error message for reference repository Aaron Schrab
2013-04-09 0:18 ` Jonathan Nieder [this message]
2013-04-08 22:46 ` [PATCH 2/2] clone: Allow repo using gitfile as a reference Aaron Schrab
2013-04-09 0:24 ` Jonathan Nieder
2013-04-09 16:31 ` Aaron Schrab
2013-04-09 16:47 ` Junio C Hamano
2013-04-09 16:50 ` Aaron Schrab
2013-04-09 22:21 ` [PATCH v3 0/2] Using gitfile repository with clone --reference Aaron Schrab
2013-04-09 22:21 ` [PATCH v3 1/2] clone: Fix error message for reference repository Aaron Schrab
2013-04-09 22:22 ` [PATCH v3 2/2] clone: Allow repo using gitfile as a reference Aaron Schrab
2013-04-09 22:41 ` [PATCH v3 0/2] Using gitfile repository with clone --reference Junio C Hamano
2013-04-07 23:48 ` [PATCH 1/2] clone: Fix error message for reference repository Jonathan Nieder
2013-04-08 0:06 ` Aaron Schrab
2013-04-08 1:11 ` Aaron Schrab
2013-04-08 13:58 ` Junio C Hamano
2013-04-08 14:57 ` Aaron Schrab
2013-04-08 15:30 ` Junio C Hamano
2013-04-08 16:17 ` Aaron Schrab
2013-04-08 17:57 ` Junio C Hamano
2013-04-08 18:58 ` Aaron Schrab
2013-04-08 19:10 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409001817.GV30308@google.com \
--to=jrnieder@gmail.com \
--cc=aaron@schrab.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).