From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: Re: segfault in git-remote-http
Date: Tue, 9 Apr 2013 13:16:23 -0400 [thread overview]
Message-ID: <20130409171623.GE21972@sigill.intra.peff.net> (raw)
In-Reply-To: <20130409084718.587e99aa7a935296867a84a1@lavabit.com>
On Tue, Apr 09, 2013 at 08:47:18AM -0700, rh wrote:
> The symptoms that this patch addresses look similar:
>
> http://article.gmane.org/gmane.mail.postfix.user/217790
>
> Quote from that thread:
> "This behavior is actually documented (SSL_set_fd() destroys
> a BIO already on the SSL handle, and creates a new BIO)."
>
> Maybe someone used to looking at git-remote-http code can
> say anything about this.
git-remote-http does not touch the openssl code itself at all. We only
talk to curl, which handles all of the ssl (and may even be built on
gnutls). So if that is the problem, then I think it may be a libcurl
bug, not a git one.
-Peff
next prev parent reply other threads:[~2013-04-09 17:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-07 16:38 segfault in git-remote-http rh
2013-04-07 16:42 ` rh
2013-04-09 15:47 ` rh
2013-04-09 17:16 ` Jeff King [this message]
2013-04-09 17:25 ` Daniel Stenberg
2013-04-12 15:20 ` rh
2013-04-09 17:41 ` rh
2013-04-09 17:47 ` Jeff King
2013-04-09 19:40 ` rh
2013-04-10 4:30 ` Jeff King
2013-04-10 16:08 ` rh
2013-04-10 18:51 ` Jeff King
2013-04-10 19:11 ` Jeff King
2013-04-10 23:31 ` rh
2013-04-13 1:01 ` rh
2013-04-10 19:16 ` rh
2013-04-10 19:54 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130409171623.GE21972@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).